jfk344 / iobroker.evsewifi Goto Github PK

I am an automatic service that looks for possible errors in ioBroker and creates an issue for it. The link below leads directly to the test:

https://adapter-check.iobroker.in/?q=https://raw.githubusercontent.com/JFK344/ioBroker.evsewifi

• [E145] No "common.news" found for actual version 1.0.2
• [E154] common.dependencies must contain [{"js-controller": ">=2.0.0"}] or later - recommended: [{"js-controller": ">=5.0.11"}]
• [E200] Not found on npm. Please publish
• [E606] Current adapter version 1.0.2 not found in README.md
• [E605] No actual year found in copyright. Please add "Copyright (c) 2023 JFK344 [email protected]" at the end of README.md
• [E701] No actual year found in LICENSE. Please add "Copyright (c) 2023 JFK344 [email protected]" at the start of LICENSE

I have also found warnings that may be fixed if possible.

• [W171] "common.title" is deprecated in io-package.json
• [W105] "common.titleLang" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)
• [W109] "common.desc" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)
• [W156] Adapter should support admin 5 UI (jsonConfig) if you do not use a React based UI
• [W145] Each "common.news" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)
• [W400] Cannot find "evsewifi" in latest repository
• [W513] "gulpfile.js" found in repo! Think about migrating to @iobroker/adapter-dev package

Thanks,\r\nyour automatic adapter checker.

P.S.: There is a community in Github, which supports the maintenance and further development of adapters. There you will find many experienced developers who are always ready to assist anyone. New developers are always welcome there. For more informations visit: https://github.com/iobroker-community-adapters/info

Dear Adapter developer,

with js-controller 3.2 and js-controller 3.3 some additional checks were added to make sure that created objects match to the specifications and also written state values match to the object definition.

If something is not correct this is logged as 'warning' or 'info' log.

Please take the time to verify your adapter by ideally starting with a fresh instance and do some actions and verify the log. If you see a warn log there from these checks please adjust the adapter and fix the relevant cases.

For questions please refer to ioBroker/ioBroker.js-controller#1301

Additionally we are preparing Admin 5 which will have a completely rewritten UI. Please install Admin 5, activate that new UI and verify that the configuration of you adapter works as expected also there.

More informations on Admin 5 can be found in Forum https://forum.iobroker.net/topic/44282/test-adapter-admin-5-0-x-alpha-der-neuen-ui

Please close the issue after you checked it.

Thank you very much for your support!

Hi @JFK344,

I have been using your adapter for more than two years now and I highly appreciate your work. I found some room for improvement, specifically the interruptCp() request I need in my setup. Since you did not answer my PR from Oct 2021, I assume you discontinued work on the evsewifi adapter.

If so, I would suggest to take over and create a new fork or even a new repo (to align the esve/evse mismatch), of course mentioning you as the original creator.

Let me know what you think, thanks
Uli (git-kick)

I installed the adapter from "master".
(I also tried tag "V1.0", but installation failed.)
The adapter starts and fills the parameters correctly, but all logs.Log_x elements remain (null)

ioBroker logging says:

In my local environment, I have fixed the issue and I would like to create a Pull Request, but I am not allowed to create a branch, according to GitHub.
@JFK344 , @foxriver76 : would you grant permissions to me or do you prefer that I create a fork on my own?

Describe the bug
I did a tcpdump while the adapter is running and there are thousands of lines. A small passage looks like this:

00:54:49.803881 IP 192.168.0.10.42522 > 192.168.0.12.80: Flags [P.], seq 0:74, ack 1, win 29200, length 74
....GET /getParameters HTTP/1.1....

00:54:49.932085 IP 192.168.0.10.42524 > 192.168.0.12.80: Flags [P.], seq 0:74, ack 1, win 29200, length 74
....GET /getParameters HTTP/1.1....

00:54:50.028123 IP 192.168.0.10.42514 > 192.168.0.12.80: Flags [P.], seq 0:74, ack 1, win 29200, length 74
....GET /getParameters HTTP/1.1....

00:54:50.188138 IP 192.168.0.10.42508 > 192.168.0.12.80: Flags [P.], seq 0:74, ack 1, win 29200, length 74
....GET /getParameters HTTP/1.1....

So, when you look at the timings, each 0.1 to 0.2sec there is a call to the evse's /getParameters page.

To Reproduce
Steps to reproduce the behavior:

1. Enable the ioBroker.evsewifi module in iobroker
2. Make a tcpdump on the OS where iobroker is running

Expected behavior
I think one request each 10 sec (or even one request each minute) should be enough.

Versions:

• Adapter version: 1.0.0
• JS-Controller version: 4.0.23
• Node version: v14.20.1
• Operating system: Synology DSM 6 --> Docker version 18.09.8, build bfed4f5 --> Debian 11 Image

Hi,
my iobroker and evse are in different subnets and don't have a direct connection. Additionally, the ports are mapped via NAT. So my evse smartWB is not reachable via port 80, but rather via port 8023.

Please, implement the possibility in the admin backend to be able to change the port.

f.ex. lines like
const url = 'http://' + this.config.ip + '/getParameters';
need to be changed to:
const url = 'http://' + this.config.ip + ':' + this.config.port + '/getParameters';

and add some lines to the file admin/index_m.html that this port can be defined in the backend.

Hi, thanks for your work. Is it possible to change the name of this repo to "ioBroker.evsewifi". I think interested people would find it better. ;-)

Dear Adapter developer,

Node.js 14 is now available for a year and Node.js 16 was release just some days ago and will become LTS by October 2021. We plan to update the ioBroker Node.js recommendation (currently 12.x) to 14.x later this year.

Please check your adapter with Node.js 14 especially, and ideally also directly with Node.js 16

Please add both versions to the adapter testing which is executed on commits.

If your adapter requires a certain minimum version of Node.js please set the 'engine' setting in package.json accordingly! Please also do this if the adapter is not able to work in certain Node.js versions, so that ioBroker can prevent users from installing te adapter if not compatible!

On questions please talk to us at ioBroker/ioBroker.js-controller#1138

Please close the issue after you checked it.

Thank you very much for your support!

I am an automatic service that looks for possible errors in ioBroker and creates an issue for it. The link below leads directly to the test:

https://adapter-check.iobroker.in/?q=https://raw.githubusercontent.com/JFK344/ioBroker.evsewifi

• [E118] Versions in package.json and in io-package.json are different
• [E145] No news found for actual version 1.0.0
• [E154] common.dependencies must contain {"js-controller": ">=2.0.0"} or {"js-controller": ">=3.0.0"}
• [E200] Not found on npm. Please publish

I have also found warnings that may be fixed if possible.

• [W400] Cannot find "evsewifi" in latest repository

Thanks,
your automatic adapter checker.

P.S.: There is a community in Github, which supports the maintenance and further development of adapters. There you will find many experienced developers who are always ready to assist anyone. New developers are always welcome there. For more informations visit: https://github.com/iobroker-community-adapters/info

Dear Adapter developer,

with js-controller 4.0 object definitions are now also checked that min/max in only provided for number/mixed objects and that the type of the default value matches to the object type.

If something is not correct this is logged as 'warning' or 'info' log.

Please also make sure to update to the lastest @iobroker/testing dependency 2.5.4 or to accept the PR from Apollon77 for legacy testing!

Please spent some time to verify your adapter by ideally starting with a fresh instance and do some actions and verify the log. If you see a warn or info log there from these checks please adjust the adapter and fix the relevant cases.

For questions please refer to ioBroker/ioBroker.js-controller#1749

Please close the issue after you checked it.

Thank you very much for your support to get the best experience for the growing numbers of ioBroker users!