jffz / ansible-netdata Goto Github PK

Solution:

- name: Netdata check if first time install    
  stat: path=/etc/netdata
  register: path_netdata

and to determine whether to install:

- name: "Installation"
  shell: cd /usr/src/netdata/ && ./netdata-installer.sh --dont-wait --libs-are-really-here
  notify:  Restart netdata
  when: gitupdate.changed or not path_netdata.stat.exists

(great project btw. Thanks)

I can integrate Travis CI and molecule with testing in docker for this role if you want :)

Examples of such config are in:

• https://github.com/cloudalchemy/ansible-prometheus
• https://github.com/cloudalchemy/ansible-grafana

Do you want it?

I think this task:

- name: install pre-requisites
  package:
    name: "{{ item }}"
    state: present
  with_items: "{{ netdata_script_dependencies }}"
  register: _install_dep_packages
  until: _install_dep_packages is succeeded
  retries: 5
  delay: 2

The 'state' part shouldn't be present but latest like so:

- name: install pre-requisites
  package:
    name: "{{ item }}"
    state: latest
  with_items: "{{ netdata_script_dependencies }}"
  register: _install_dep_packages
  until: _install_dep_packages is succeeded
  retries: 5
  delay: 2

I noticed this when running your role on a host that already had all software installed just not the latest version. Reinstalling the dependencies manually on the host with apt solved all the issues I had with this role. Can you adapt the role so it updates the dependencies when updating/installing?

Thanks for the role, I use it a lot!

Hi Geoffrey and thanks for this Ansible role! I've been using it for over a year and it saved me tones of time!

I'm opening this issue after upgrading my local copy of your role and seeing these two warnings when applying it:

[WARNING]: file /path/to/roles/jffz.netdata/tasks/configure.yml is empty and had no tasks to include
[WARNING]: file /path/to/roles/jffz.netdata/tasks/install_release.yml is empty and had no tasks to include

Deleting these two empty files does not help, but there is still something we can do to suppress the warnings. Just adding this yaml to both files seems to do the trick:

---
[]

What do you think of making this change?

It would be nice to include LICENSE file, without this file using this repository is basically illegal in most cases.

I propose to use MIT license. More information is provided by github: https://help.github.com/articles/licensing-a-repository/

This can be easily done with github GUI: https://help.github.com/articles/adding-a-license-to-a-repository/

Hi,
I want to netdata configure/install only python modules on my machines. With variable in playbooks I need configure to install only this modules?

Thank you for the time