jesusgollonet / ofxgifdecoder Goto Github PK

Looking at the code (specifically ofxGifDecoder::createGifFile), it seems that there is no alpha channel. I'm I safe in assuming that gifs cannot have transparency at this point, or am I mistaken?

Hello!

I'd love to use your code in my project, and improve on it so it doesn't crash a ton. Can you please license it under the MIT License? (openFrameworks and most other addons use this license.)

the
case GIF_DISPOSAL_UNSPECIFIED:
_px.setColor(x,y,accumPx.getColor(cropX, cropY));
accumPx.setColor(x,y,_px.getColor(cropX, cropY));

line in ofxGifFile causes a hard crash with many gifs. maybe 35% of all gifs. I've spent the entire evening trying to get it to work and i can load every gif file if i always set accumPx (to a color) at the beginning of the "addFrame" function. It however introduced horrible artifacts of color. Its tough.. this thing you've made is amazing and works so well, except when it doesn't. I've kind of taken the debugging as far as i can without knowing why the whole thing works the way it does.

here are 3 gifs that ofXGifDecoder is unable to load: https://www.dropbox.com/sh/7ch5dsq9ctzg4jf/AABCD5DEToP-H_GHjAhJdYYOa?dl=0

is there some miracle chance you could take a look at this?

ofxDecoder.cpp

This addon is giving me this error:
undeclared PixelType definition.

The line of code looks like this:
unsigned int channels = (bpp / sizeof(PixelType)) / 8;

Hi, i imported your files, and it seems the decoder file gets the app stuck on this error.

it gets stuck in the getpixel(int x, int y) function, in the if(channel == 4) line.

this one: c.set( pixels[index], pixels[index+1], pixels[index+2], pixels[index+3] );

any idea how to fix it?

thanks in advance.

Jan

I've isolated it to the "ofxGifDecoder::processFrame(FIBITMAP * bmp, int _frameNum)" function.

Quite a large leak for anyone using this addon

trying to open a gif created with ofxGifEncoder, only a white frame is produced.
I can open the gif created with ofxGifEncoder in various programs in windows.
However, trying to load it via ofxGifDecoder or ofImage will result in a white frame.

When trying to load an animated gif using ofxGifDecoder, I'm not able to load more than 1 frame. All frames after the first loaded page show up blank.

Weirdly enough, I encounter this issue when trying to run pure freeimage examples too, so it may be a bug all the way back in their library? Just curious as to if anyone else has seen this issue also.

Using freeimage 3.15.1, head of openFrameworks and ofxGifDecoder repo as of 2012-10-25.

(Speaking of, ofxGifDecoder doesn't compile out of the repo due to what looks like some copy/pasted code from ofxCore (using PixelType template without actually declaring the template type)? Will submit pull request for that fix)