jeroenbakker-atmind / rs-audio-engine Goto Github PK

Currently for every note the instrument needs to be set. The time doing this can be reduced when
the instrument doesn't change.

• in Row/Event separate the note event from the instrument
• Don't remove instrument when a note is finished (NoteOff event)

• Create a track with a note on event, note release event and a second note on event.
• When rendering only the first note is rendered. the second note is not audible.

Originally the pitch was copied from a document that contained 2 fraction numbers. This might not be 100% accurate and perhaps it is better to calculate the pitch using math for performance reasons as well. Current implementation can use a lot of branching and spill branch prediction tables.

When using physical instrument models the amplitude is considered an input value during evaluation. Current implementation of DigitalSound performs amplification as a post sample process. In the tracker this is even a separate attribute of a row.

• Bundle Sound::sample parameters to its own struct. The parameter type might become a template type.
• Add gain to this struct
• Change all sound implementations to evaluate the gain (or forward this responsibility)
• Add gain to hammer speed control to PianoInstrument.