jeffluong / project_04_hue_square Goto Github PK

Good

• great design
• easy usability
• great idea
• code is well formatted
• your JS code is really well abstracted out into its different components

Improvements

• share functionality
• save feature
• in general, I define my functions within the constructor class using this. That way the function has access to any private variables/functions should you choose to add them later. I only use prototype when extending a library whose code I don't want to touch directly
• I would suggest putting library JS in a separate directory. That way you keep your code separate

Overall
I can't stop playing!!! Really great idea, really great design. Figure out a way to monetize it, then get someone to build an android/iphone app. Alternatively, both iPhone and Android can have an app which is just a web page. This is a quick solution that you could probably pull off. You've got a really good product here. Take it to its final stage. This is the best final project I've reviewed so far. Congrats!