Comments (8)
@dcousens Thanks for looking. Actually it is very simple if you care. You have each js file with import and export. Before publishing you use tool like rollup or babel to convert modules to UMD format used now (actually amd defined bad).
For other people comming there you can use for now classnames-es
package.
from classnames.
webpack hack to add exports.default:
webpack.config.module.rules.push({ test: /classnames/, use: ['exports-loader?default=module.exports'] })
from classnames.
I was having problems importing this module into TypeScript for this very reason. Changing the export code in this library to the following fixes it:
Object.defineProperty(exports, "__esModule", { value: true });
exports.default = classNames;
Now I can import with:
import classnames from 'classnames';
But I have to add the compiler flag --allowSyntheticDefaultImports
to make that work, because the TypeScript definitions don't declare a default export.
Related to #103
from classnames.
@btd do you mean you want a copy of the library using export
/import
?
I don't think that will be a simple thing to maintain... at all
from classnames.
Before publishing you use tool like rollup or babel to convert modules to UMD format used now (actually amd defined bad).
And there is the kicker. That isn't simple, and can be a pain to keep up to date.
from classnames.
For other people comming there you can use for now classnames-es package.
@btd maybe you can make a PR to put that in the README?
from classnames.
Unless @JedWatson (or @btd) wants to make a classnames/es
file.
from classnames.
@jedmao You can use classnames in TypeScript without --allowSyntheticDefaultImports
like this:
import * as cx from "classnames"
from classnames.
Related Issues (20)
- why not using one build tool for publish the npm package? HOT 2
- Incomplete type signature for classnames/bind HOT 2
- Advanced typing for classnames/bind HOT 4
- Explain to me about "cx" HOT 1
- Getting error says 'this' context of type 'void' is not assignable HOT 4
- [Question] When I used Object's value to computed key, what happened? HOT 2
- SyntaxError: Unexpected end of script (Mobile Safari) HOT 5
- When no classes are selected, classNames should return null HOT 5
- Vulnerable dependencies (indirect security issues) HOT 1
- How to erase or replace the properties of the conditional class from external component? HOT 1
- why number can be a className HOT 1
- Can we add exports field for this package? HOT 4
- Need a maintainer? HOT 7
- Preparing for version 3.0 HOT 9
- Should we support CommonJS for 3.0? HOT 5
- No default export (v2.5.1) HOT 5
- Import from 'classnames' broken since v2.5.0 HOT 5
- Please use GitHub Releases HOT 6
- Unable to do v2 releases HOT 2
- Feature Request: Enhanced Responsive Classnames Support HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from classnames.