Code Monkey home page Code Monkey logo

Comments (8)

btd avatar btd commented on August 20, 2024 2

@dcousens Thanks for looking. Actually it is very simple if you care. You have each js file with import and export. Before publishing you use tool like rollup or babel to convert modules to UMD format used now (actually amd defined bad).
For other people comming there you can use for now classnames-es package.

from classnames.

yinghaochan avatar yinghaochan commented on August 20, 2024 2

webpack hack to add exports.default:

webpack.config.module.rules.push({ test: /classnames/, use: ['exports-loader?default=module.exports'] })

from classnames.

jednano avatar jednano commented on August 20, 2024 1

I was having problems importing this module into TypeScript for this very reason. Changing the export code in this library to the following fixes it:

		Object.defineProperty(exports, "__esModule", { value: true });
		exports.default = classNames;

Now I can import with:

import classnames from 'classnames';

But I have to add the compiler flag --allowSyntheticDefaultImports to make that work, because the TypeScript definitions don't declare a default export.

Related to #103

from classnames.

dcousens avatar dcousens commented on August 20, 2024

@btd do you mean you want a copy of the library using export/import?
I don't think that will be a simple thing to maintain... at all

from classnames.

dcousens avatar dcousens commented on August 20, 2024

Before publishing you use tool like rollup or babel to convert modules to UMD format used now (actually amd defined bad).

And there is the kicker. That isn't simple, and can be a pain to keep up to date.

from classnames.

dcousens avatar dcousens commented on August 20, 2024

For other people comming there you can use for now classnames-es package.

@btd maybe you can make a PR to put that in the README?

from classnames.

dcousens avatar dcousens commented on August 20, 2024

Unless @JedWatson (or @btd) wants to make a classnames/es file.

from classnames.

dlindenkreuz avatar dlindenkreuz commented on August 20, 2024

@jedmao You can use classnames in TypeScript without --allowSyntheticDefaultImports like this:

import * as cx from "classnames"

from classnames.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.