jeancochrane / findsepta Goto Github PK

Not super high priority, but we should probably be testing that is in the list of routes before sending it along to SEPTA. Could be a security problem in a slightly different program (making a request from unsanitized user input) and should definitely throw an exception instead of getting an error from SEPTA.

See line 30 of app.py

Unfortunately, the route line information served by SEPTA isn't contiguous, so we can't model the movement of vehicles along their route. Once the map debugger is up and running we should try to clean these up and make them useable.

Get rid of the Bottle; switch to Flask instead.

Right now the hover effect on the bus stops is done through the Mapbox api and the mouseMove event – could be replaced with CSS (:hover styling) and a custom marker for both performance and customization reasons. The cursors can also be changed to pointers via CSS instead of JS, over both the buses and the stops.

Bus data doesn't update in Safari! Opening the debugger shows javascript throwing an error "Object.values is not a function" – because it's not supported in Safari.

For reference:
Object.values

Combobox currently has a bug where if you don't manually select the suggested route from the drop-down menu before sending the form (either by hitting "Find SEPTA" or the return key) it sends a request for the default route (2). Not the end of the world, but it makes for unintuitive UX.

Map debugger should probably be its own separate page, routed through app.py. (Potentially a good standalone service?)

Weird spacing between combobox and button. Button should be centered or on the right.

Github link disappears at this width but there's plenty of room.

About/github icons are outside of their parent container.

This one's just a mess 🙃🙃🙃

:D

Rather than requesting new data every 5 seconds, we could consider opening a request to the server that will only be completed if the data changes (and otherwise will time out and be repeated by the client). Here's a guide to doing that with bottle.

Alternatively, we could switch to node.js for the backend and use socket.io to update via websockets.

Something like this. We need to:

1. Retrieve SEPTA real-time data from our back-end
2. Clean it; test for mislabelled and unlabelled vehicles, as well as vehicles that are off their routes
3. Serve data through an API