je-el / cs321_lab03 Goto Github PK

There is an issue with calling anything with clientSocket as clientSocket has not been declared in the scope or globally. Unless declared within main.
It seems that sock should be used here instead since its the variable holding the socket file descriptor.

See following errors inheriting this issue:

NewClient.c:66:19: error: use of undeclared identifier 'clientSocket'
                int read = recv(clientSocket,data,1024,0);
                               ^
NewClient.c:72:12: error: use of undeclared identifier 'clientSocket'
     send (clientSocket, input, 1024, 0);
          ^
NewClient.c:74:18: error: use of undeclared identifier 'clientSocket'
     read = recv(clientSocket,data,1024, 0);
                ^

valread needs to be a pointer or function pointer to prevent this error on compilation

NewClient.c:87:23: error: called object type 'int' is not a function or function pointer
        valread = read(sock , buffer, 1024);
                  ~~~~^

the scanf function in the client function is reading only one word of input, to read a full line including whitespace, etc try using fgets instead.

read cannot be used here as a variable, this may be a mistake and needs to be renamed.

On Line 74 this read variable has no relation to read() function. It is simply used to store the return value of the recv() function which reads data from the socket.

so rather try using something like:

int socketRead = recv(clientSocket,data,1024,0);

5. The process should not end only after one pass of message between server and client as it is now. Server will only stop if one of the clients sends ‘BYE’ message

3. Currently the server is accepting a client message (request) and sending a response message to the same client. In your new version, the server should forward the accepted message from one client to the other client.

1. In the current version there is only one client. But you must create two different clients.

4. The server should work properly only when two clients are up and connecting to it. If there is only one client connecting to the server then, the server will send a message complaining “only one client is up”

8. You may need to send the client process pids to the server to establish the connection

7. For the sake of simplicity, assume that both your client and servers are on the same machine i.e. localhost (127.0.0.1)

6. The server process should be designed in such a way so that it cannot be aborted by hitting ctrl-c on that terminal

2. Currently the messages are hardcoded in the program. But your code must read the client messages from the user.