jdogresorg / freewallet-desktop Goto Github PK

It seems the minimum BTC order amount is 0.001 BTC. Update order interface to throw error if BTC buy or sell amount is less than 0.001.

https://github.com/CounterpartyXCP/counterparty-lib/blob/e875c45c586cc4fc840a59540a6d44bd03ee698b/counterpartylib/lib/messages/order.py#L436

We want to avoid wasted fees on orders like this https://xchain.io/tx/1489623

In order to prevent confusion and detect possible frauds, the UI could highlight the FULLACCESS dispenser provided by Freewallet. (other options could still be shown, since somebody can offer a lower price for a "little used" tokens)

Add support for multiple languages

Probably want to use javascript localization library like : https://github.com/eligrey/l10n.js

Look into adding support for the following hardware wallets :

• Trezor - https://gist.github.com/sorce/396fe44739392756abac8c2e213bb11e
• Ledger - https://github.com/mandelmonkey/ledger-cp
• KeepKey
• OpenDime.

As far as how to display the hardware wallet addresses/balances, thoughts are :

• Add option to 'Watch-Only' addresses to indicate this is a hardware wallet address
• Add new "Hardware Wallet Address" type

It seems that the current release forces the tx fee to 1000 satoshis on both the pre-tx and the mpma-tx instead of just the pre-tx, which is resulting in a high tx fee (27.1 sat/byte)

Need to fix createMultiSend() to pass fee forward in API call and verify that specified fee is used in raw tx data

https://github.com/jdogresorg/freewallet-desktop/blob/master/js/freewallet-desktop.js#L2225

placed an order to SELL BACHELORPEPE
cannot cancel it because it doesn't show up on the "my open orders" in freewallet

As it says, when opening a counterparty: URI on windows, the name registered for the URI handler scheme says the name of the runtime "nwjs". Attached is a screenshot (in spanish though)

Issue moved from XChain repo.

Need to get more helpful error messaging to bubble up to the surface in Freewallet... so errors are not a black hole.

if I enter a memo and try to do a send, nothing happens... sending without memo is fine... find out why and fix

Need to update the app to display some sort of a status indicator to indicate what exactly wallet is doing

• generating transaction
• looking up utxos
• signing transaction
• broadcasting transaction

Right now you click "OK" to approve action and you get hung for a while with no indication of what is going on

Need to update the wallet to remove any dependency on bitcore and use bitcoinjs instead.

When trying so send out some crypto. it says "error server with counterparty" yesterday was working perfectly. can you please with the issue ?

Add the ability to switch between different seeds without having to log out and in back and forth.

When we get multiple order matches in the same block, and try to send multiple BTCpay transactions at the same time, some are failing and I am getting a "Broadcasting another transaction too quickly" message.

Need to update BTCpay code to reset the broadcast lock before trying to broadcast

It would be a nice feature to be able to type an asset name into the address input box and have freewallet automatically lookup the asset owner address and populate the field with the address.

ie... I type in JDOG in the address slot and it is automatically changed to 1Lfm6jXgCQi8LvjpgFHa2F4hdr1uJVa5t4

Cant cancel my old orders :)

Using SSL with api.counterparty.io fails on CORS errors. Need to update proxy settings to pass correct headers in response to pass OPTIONS preflight checks.

Need to update to latest version and make sure all is working as it should... getting build warnings now.

npm notice created a lockfile as package-lock.json. You should commit this file. npm WARN notsup Unsupported engine for [email protected]: wanted: {"node":"~0.10.1"} (current: {"node":"12.18.1","npm":"6.14.10"}) npm WARN notsup Not compatible with your version of node/npm: [email protected]

I'm trying to send BCY & XCP. When I click send, I get the error "Error while trying to sign send transaction".

I have tried over the last several days. Still no luck.

I'm using 0.9.9,

Please advise.

Please update the downloads page for freewallet.io to include checksums when time allows. Thanks!

Currently when a user issues supply in freewallet-desktop, the description field is not being passed forward, resulting in the description field being blanked out.

Need to fix this issue so that we pass the current asset description along in the create_issuance API call.

On the basic information view, there's no way to tell when an asset is locked or not.

Need to have better error handling on segwit transaction signing... right now segwit tx signing can fail and no indication is shown in wallet UI to indicate a failure.

Wrap signing code in try/catch block to capture unexpected signing errors and update UI to indicate error

When your using Freewallet, you can't actually see the BTC/XCP amounts held in addresses in the "Address List" until after you switch to the wallet address and pull down balance/BTC info for the first time for an address.

Need to update wallet to preload BTC and XCP balances for all wallet addresses so they show correct balances in address list. The lack of a balance showing until after an address is loaded is causing some people to think they have no BTC in their addresses and ask customer support questions.

Need to alert a user whenever their tx fee is below the minimum relay fee (currently 0.00001000) and notify them that the transaction will NOT show up on many block explorers until the transaction is mined due to the low fee.

Make the alert optional so that users can disable it if they don't want to keep getting notified of low fee transactions.

Numbers not so explicit with this format. I understand that mathematical it could be correct, but wouldn't be an alternative trying to have one of the paired asset be " 1 " or the number of units on sale (e.g. here " 5 ") ?

The transaction is https://xchain.io/tx/1378606 :
Buy Quantity | Sell Quantity
240  BITCRYSTALS | 5 LATOMOO

I would like to set the fee in sat/b instead of only being able to set absolute values.
This would include the option to send 0-fee transactions.

With new arm64 Linux phones (among other laptops etc) now on the market, there is currently no Bitcoin wallet available. Would you be able to package this for arm64, and ideally have the UI be "adaptive", as in work on a mobile screen resolution?

Need to update app to include multiple themes.

Currently freewallet only supports generating addresses using the same method as counterwallet with a different derivation path than BIP39.

Need to update FreeWallet to handle generating addresses in both BIP39 and "Counterwallet" formats.

Need to add some code to MPMA sends to verify if asset is divisible or non-divisible and force quantity to correct format

Right now users are doing sends like
1ADDRESS, MAFIACASH, 1

Expecting that it will send "1" MAFIACASH and the actual behavior is sending "0.00000001"....

Need better quantity validation on MPMA sends

• Notify users when orders expire or are filled
• Allow users to setup a watchlist of tokens - notify if a buy/sell order is placed for X asset

It would be nice to be able to use this wallet software over Tor network. This would also allow users of Whonix, Tails and similar to easily use Freewallet, e.g.

If I open Freewallet and point it to the socks5 proxy:
$ freewallet --proxy-server=socks5://127.0.0.1:9050 (or whatever port you're using)

Then it works great for watching addresses, but sending transactions does not work because the wallet cannot retrieve the BTC balance. It seems that chain.so and blockcypher APIs do not accept requests from Tor network. blockstream does, but for some reason it looks like the call to blockstream does not seem to get made.

In https://github.com/jdogresorg/freewallet-desktop/blob/master/js/freewallet-desktop.js it looks like blockstream should be the second attempt if I'm reading it correctly (questionable assumption) Here is a screenshot of the console messages:

Thanks and keep up the great work!

Where to go to Download FreeWallet.exe?
I did a search for .exe file under code and was not able to locate.

Currently the wallet is still showing orders which have a status of 'Open' but which have 0 balances.

Need to update the wallet to hide orders with 0 buy/sell remaining quantity

need to update wallet to prevent people from doing MPMA sends from segwit addresses until we figure out the change issue (change being sent to wrong address).... only happens on segwit for mpma.. single sends are fine

Verify we have issue, then get warning in wallet ASAP to prevent usres from losing BTC

Need to notify the user whenever the license changes and force them to review/accept the changes before allowing continued use of the wallet.

A.) Remove 'licenseAgreementAccept' from localStorage
B.) Notify user of license change.. clicking OK launches dialogLicenseAgreement()

hello
i've downloaded FreeWallet.linux64.tgz from v0.9.12 release.
extracted in a directory.

install
/mnt/shared/crypto/FreeWallet$ sudo ./install.sh

Creating installation directories...

mkdir: created directory '/usr/share/FreeWallet'
mkdir: created directory '/usr/share/icons/FreeWallet'

Installing FreeWallet...

Integrating FreeWallet with linux desktop...

Setting file permissions...

Updating desktop database...

Error in file "/usr/share/applications/org.kde.kdeconnect_open.desktop": "/" is an invalid MIME type ("*" is an unregistered media type)

Installation Complete!

first error.

if i try to run it
$ /usr/share/FreeWallet/FreeWallet
Bus error

thanks for any help ..

Need to update the wallet to automatically lock itself after a given time period.

Probably best solution would be to allow user to select a duration of how long the wallet should remain unlocked when they unlock the wallet and enter a password

Add the ability to cancel an order to the main menu.... user should just have to paste in the tx hash or tx id# of the order they want to cancel..... Having to navigate to the market and "My Open Orders" can be a bit of a pain at times.

Need to update MPMA sending to create array of memos and pass memo and memo_is_hex lists

https://github.com/CounterpartyXCP/counterparty-lib/issues/1065

Would be nice to have RBF support in the wallet and have a simple solution available for users who complain about their transactions being pending.

https://medium.com/@overtorment/bitcoin-replace-by-fee-guide-e10032f9a93f

Need to update dispenser screen to support creating empty dispensers (open dispenser on new address)

Also should add a warning to the user if they are attempting to setup multiple dispenser on the same address... a simple warning should be enough to scare most people away from doing this.

Need to update cpRequest() function to handle failures... currently only handling successes and no indication of error on failure.

Whenever a user performs an action, they should get some type of success or error message.

Need to update wallet to check if address that dispenser is being setup on has any asset or BTC history, and if YES, throw a scary message about not setting up dispensers on addresses that you use in everyday use and to use a new/dedicated address for a dispenser.... give option to continue setting up dispenser, but scary message should hopefully stop people from setting up vending machines and then triggering the machine themselves with BTC sends of withdraws from exchanges to their address with a dispenser.

Need to add support for additional fiat currencies.

Probably want to include the following to start:

USD = US Dollar
AUD = Australian Dollar
BRL = Brazilian Real
CAD = Canadian Dollar
CHF = Swiss Franc
CLP = Chilean Peso
CNY = Chinese Yuan
CZK = Czech Koruna
DKK = Danish Krone
EUR = Euro
GBP = British Pound
HKD = Hong Kong Dollar
HUF = Hungarian Forint
IDR = Indonesian Rupiah
ILS = Israeli New Shekel
INR = Indian Rupee
JPY = Japanese Yen
KRW = South Korean Won
MXN = Mexican Peso
MYR = Malaysian Ringgit 
NOK = Norwegian Krone
NZD = New Zealand Dollar
PHP = Philippine Peso
PKR = Pakistani Rupee
PLN = Polish Zloty
RUB = Russian Ruble
SEK = Swedish Krona
SGD = Singapore Dollar
THB = Thai Baht
TRY = Turkish Lira
TWD = New Taiwan Dollar
ZAR = South African Rand

Will need to update xchain.io/api/network API call to include currency data in following format :

{
    "price_XXX": "4791.10914975",
    "24h_volume_XXX": "2550856271.25",
    "market_cap_XXX": "79635717781.0"
}

Get current prices for all of these currencies via calls to coinmarketcap API:
https://api.coinmarketcap.com/v1/ticker/bitcoin/?convert=CAD
https://api.coinmarketcap.com/v1/ticker/bitcoin/?convert=EUR
...
https://api.coinmarketcap.com/v1/ticker/counterparty/?convert=CAD
https://api.coinmarketcap.com/v1/ticker/counterparty/?convert=EUR

Need to go back through the app and update fee estimation to calculate fees based on actual tx size and not average

• Use average tx size only for initial tx fee calculation (assume 1 input)
• Do pre-flight check of tx to determine actual tx size
• Notify user if actual tx size differs from average so they can re-adjust fee.

Desktop: option to remove BTC and XCP Markets and set personal default market

Allow users to set a default fee amount when selecting "Custom" fee type.

I want to send all my transactions for super-cheap at 0.00001 ..... I keep having to re-type it for every transaction, it is a pain, fix it.

I purchased an code-signing certificate for "Jeremy Johnson" so I can sign windows binaries and stop getting the "Unknown Developer" popup.

Need to update build.sh to include signing windows builds