Hi what do you think about Sourcery (https://github.com/krzysztofzablocki/Sourcery)
It generates generates some of the duplicate/boilerplate code for you

I think that model protocols for every model have identical structure and could be removed (moved to autogenerated file) with this
See this gist,
https://gist.github.com/vaderdan/cfd9ef853f123143e580ec2e3664a8c1
Basicaly it scans for classes that extends Automodel and make protocols with inputs/outputs from them

https://www.caseyliss.com/2017/3/31/the-magic-of-sourcery

First of all I would like to thank you for this amazing project. Truly your project has become an educational resource for me!

My question is about the SceneCoordinator. I implemented the Coordinator with the same logic without RX, because I don't have the enough confidence to start using RX in projects for production. I have only one missing link to intercept when the View Controllers pop or a tab bar item is changed you make the SceneCoordinator the navigationControllerDelegate and tabBarControllerDelegate. I am wondering what the difference between this:

currentViewController.navigationController?.rx.delegate.setForwardToDelegate(self, retainDelegate: false)
currentViewController.tabBarController?.rx.delegate.setForwardToDelegate(self, retainDelegate: false)

And this code is:

currentViewController.navigationController?.delegate = self
currentViewController.tabBarController?.delegate = self

I'm guessing RX has a fancy way of preventing memory leaks in this case. How can I make my own implementation of setForwardToDelegate? Again thank you very much!

Show full date on each photo if the date is greater than 1 week

show an alert if something goes wrong during authorisation

Could you please write some tests for the view models and some important parts of the application to demonstrate unit testing in this architecture.

The guest user can use the app, but when it comes to the actions that require outside the public scope, the guest user should be invited to Login with Unsplash.

Since you have put photoDetailsAction in HomeViewCellModel to transition to photoDetails. Now if I want to use tableView.rx.itemSelected. I have to put it in HomeView layer. Is it a little weird to do similar logic in different layers? One in view, one in cell?
How would you write the code? Thx

Papr/Coodinator/SceneCoodinator.swift

static func actualViewController(for viewController: UIViewController) -> UIViewController {
    var controller = viewController
    if let tabBarController = controller as? UITabBarController {
        guard let selectedViewController = tabBarController.selectedViewController else {
            return tabBarController
        }
        controller = selectedViewController
    }
    if let navigationController = viewController as? UINavigationController {
        return navigationController.viewControllers.first!
    }
    -return viewController  
    +return controller
}

We could add pan gesture recogniser on DetailsScreen and dismiss the photo interactively

https://github.com/HeroTransitions/Hero/wiki/Interactive-Transition

@jdisho wdyt

After interactively dismissing PhotoDetailsViewController, pushing another view controller does not work. This bug was introduced in #72 @vaderdan.

Zoom in/out a photo in PhotoDetailsView.

How many modification needed do you think if to use Firebase as backend to store all the data instead of from unsplash?

Click on "..." to share a photo via UIActivityViewController

We can add some subtle animations when show the photos or when scroll the list/collectionview

https://uimovement.com/ui/1962/curated-playlists/
https://uimovement.com/ui/836/craiglist-mobile-animation/
https://uimovement.com/ui/5711/playlist-interaction/

Maybe use this lib
https://github.com/willowtreeapps/spruce-ios?ref=ioscookies.com

What do you think about this profile page design

https://uimovement.com/ui/4479/photo-app/

I found this bug
When I like photo in details screen and then go back, the tableview photo stays with unliked

Be able to download and save photos on camera roll

When I go to search screen -> enter something in search bar -> tap on Photos with ...
it show all the photos, but when I tap on any of the search results (photos) it does nothing

I should open detail photo screen

When you go on the search, I'm unable to dismiss the keyboard

It should hide when I press on table cell or anywhere on the screen (tableView itself)

1. Start the app with no internet connection.
2. Error comes up.
3. Go online
4. Refresh

Since the subscription is ended, no photos will be emitted.

If app is runned from Xcode, it is all ok, otherwise app will do nothing because can't obtain Unsplash Constants from Enviroment Variables. See https://stackoverflow.com/a/14214923 .

Since SVG format is not supported in iOS, the app crashes when it tries to access an image with a given resource name.

static var arrowUpRight: UIImage {
    if #available(iOS 13.0, *) {
        return UIImage(systemName: "arrow.up.right", withConfiguration: symbolConfigurationMedium)!#
    }
    return UIImage(imageLiteralResourceName: "arrow.up.right") // #CRASH
}

We can solve this issue by (I would like to avoid having a dependency for this use case) by converting the SVGs into .png or supporting iOS13 and higher.

Thoughts on this @serjooo (since you closed #89) ?

(This app is not planned to be released, so supporting only the latest iOS version seems fine to me.)

Show photo details when tapping on a photo

As @serjooo mentioned:

App crashes still on iOS 12 in the HomeViewController on line 82:

outputs.isRefreshing
.execute { [weak self] isRefreshing in
    if isRefreshing {
        self?.collectionView.scrollToItem(at: IndexPath(item: 0, section: 0), at: .top, animated: false)
        self?.collectionView.setContentOffset(CGPoint(x: 0.0, y: -(self?.refreshControl.frame.height ?? 0.0)), animated: true)
    } else {
        self?.collectionView.setContentOffset(.zero, animated: true)
    }
}
.bind(to: refreshControl.rx.isRefreshing)
.disposed(by: disposeBag)

Commenting out the isRefreshing code solves the problem as the app crashes on scrolling logic.

Use SFSymbols only for iOS 13.

On the photo detail, swipe left-right to see the prev-next photo. This means that the PhotoDetail.swift should be a UICollectionViewCell instead of a UIViewController.

I noticed the app on iOS 13 has an issue on scene-coordinator because of the new behavior of iOS 13 modal( ‘pull-to-dismiss‘). I think the coordinator is not getting this event to pop the current view from the navigation stack. Below is the error after trying to present VC once the previous VC dismissed by "pull-to-dismiss".

Warning: Attempt to present <XX:ViewController: 0x7f96b955f590> on <XX:ViewController: 0x7f96b9621de0> whose view is not in the window hierarchy!

I would like to have a setting page. The settings page should give the possibility to:

• Logout.
• Switch between different Unsplash accounts.
• Report a bug.
• Change theme (Light <-> Dark)
• Change app icon.

Show the full comment

I want to have to possibility to create a new collection and add a photo there.

Replace alerts with JDToaster.

I will be cool if we could implement parallax images scroll

https://github.com/jdisho/ParallaxScrolling

(images in each cell moves with different speed than the scroll)

git clone https://github.com/jdisho/Papr.git
cd Papr
pod install
open Papr.xcworkspace

and cmd+R compile failed ?
Has anyone encountered this problem ?

If two model struct share some common properties, how to extract them to avoid writing the same code for twice? Now my solution is using class and inheritance. Thx for help.

I imitated your code.
After I press the select button, isLikedByUser is always the initial value.

PostViewCellModel.swift

import Foundation
import RxSwift
import Action
import RealmSwift

protocol PostViewCellModelInput {
    var selectPostAction: Action<Post, Post> { get }
    var unselectPostAction: Action<Post, Post> { get }
}
protocol PostViewCellModelOutput {
    var postData: Observable<Post> { get }
    var isSelected: Observable<Bool> { get }
}
protocol PostViewCellModelType {
    var inputs: PostViewCellModelInput { get }
    var outputs: PostViewCellModelOutput { get }
}

final class PostViewCellModel: PostViewCellModelType, PostViewCellModelInput, PostViewCellModelOutput {
    var inputs: PostViewCellModelInput { return self }
    var outputs: PostViewCellModelOutput { return self }
    
    lazy var selectPostAction: Action<Post, Post> = {
        Action<Post, Post> { [unowned self] post in
            let configuration = Realm.Configuration(deleteRealmIfMigrationNeeded: true)
            let realm = try! Realm(configuration: configuration)
            
            let sharePost = SharePost()
            sharePost.ref = post.ref!
            sharePost.title = post.title
            sharePost.summary = post.summary
            sharePost.url = post.url

            try! realm.write {
                realm.add(sharePost, update: .modified)
            }

            return .just(post)
        }
    }()
    
    lazy var unselectPostAction: Action<Post, Post> = {
        Action<Post, Post> { [unowned self] post in
            let configuration = Realm.Configuration(deleteRealmIfMigrationNeeded: true)
            let realm = try! Realm(configuration: configuration)
            let sharePost = realm.objects(SharePost.self).filter("ref = %@", post.ref!)
            
            if (sharePost.count > 0) {
                try! realm.write {
                    realm.delete(sharePost.first!)
                }
            }
            
            return .just(post)
        }
    }()
 
    var postData: Observable<Post>
    var isSelected: Observable<Bool>
    
    private let service: PostServiceType
    private let cache: Cache
    private let sceneCoordinator: SceneCoordinatorType
    
    init(post: Post, service: PostServiceType = PostService(), cache: Cache = Cache.shared, sceneCoordinator: SceneCoordinatorType = SceneCoordinator.shared) {
        self.service = service
        self.cache = cache
        self.sceneCoordinator = sceneCoordinator
        
        postData = Observable.just(post)
        let cachedPostData = cache.getObject(ofType: Post.self, withId: post.ref ?? "").unwrap()
        
        isSelected = self.postData.merge(with: cachedPostData)
            .map { post in
                let configuration = Realm.Configuration(deleteRealmIfMigrationNeeded: true)
                let realm = try! Realm(configuration: configuration)

                if realm.object(ofType: SharePost.self, forPrimaryKey: post.ref!) != nil {
                    return true
                } else {
                    return false
                }
            }.unwrap()
    }
}

PostViewCell.swift

import Foundation
import UIKit
import RxSwift
import RxCocoa
import RealmSwift

class PostViewCell: UITableViewCell, BindableType, NibIdentifiable & ClassIdentifiable {
    var viewModel: PostViewCellModelType!
    
    @IBOutlet var selectButton: UIButton!
    
    private var disposeBag = DisposeBag()

    func bindViewModel() {
        let inputs = viewModel.inputs
        let outputs = viewModel.outputs
        
        Observable.combineLatest(outputs.isSelected, outputs.postData)
            .bind { [weak self] in
                self?.selectButton.rx.bind(to: $0 ? inputs.unselectPostAction: inputs.selectPostAction, input: $1)
            }
            .disposed(by: disposeBag)

        outputs.isSelected
            .map { $0 ? UIColor.init(red: 210 / 255, green: 233 / 255, blue: 1, alpha: 1) : .clear }
            .bind(to: self.rx.backgroundColor)
            .disposed(by: disposeBag)
    }
}

*Open for suggestions how it should look like

A photo at Home is not updated when it is liked/unliked from PhotoDetails

Moya provides the solution 'multipleTarget' to seperate different kinds of API in many files. Maybe it is a better choice in the project.

Start with #89 first.

Show more info for every photo:

• Location (... and other meta data).
• Related photos.
• Featured collections.
• Related tags.

Start with #92 first.

Thx