jderochervlk / family-calendar Goto Github PK

I've noticed that you use my library rescript-struct and decided to take a look.

Here are some suggestions:

1. In pattern matchings you don't need to specify from which module Ok and Error comes. So you can change Belt.Result.Ok->Ok and Belt.Result.Error->Error, rescript compiler will figure out the rest.

2. Instead of Belt it's much better to use Core

3. The rescript-struct's is an object with some data which is not in a very readable format (because of the way how variants compiled to Js). So here you can use err->S.Error.toString instead of JSON.stringifyAny(err), to get a human-readable error message.

4. Hehe, a committed secret 😅 https://github.com/jderochervlk/netlify-functions/blob/2875b736d52f1e03be0a8df51d0936d8c8896b10/src/faunadb.res#L16

5. About accessing env variables like here. I have a library rescript-envsafe to do it more reliably.

Besides this, I'm really happy to see new people in the ReScript community. Good luck!