jdaudier / codermatch Goto Github PK

SQL Injection: http://brakemanscanner.org/docs/warning_types/sql_injection/
Location: CoderSearchesController#show

Possible SQL injection (around line 19)
User.where("languages.language" => (params[:language]), :level => (params[:level]), :remotable => (true))

https://github.com/jdaudier/codermatch/blob/master/app/controllers/coder_searches_controller.rb#L19

if/else statement with @current_user is not working in user model - this is how we're trying to prevent viewing of github users on gmaps of front page

ask Stephane how to get @current_user to work in model

Forgery protection was removed when Nathaniel trouble-shooted our issue with having current_user recognized outside of pages#index. He said we had problems because our form is html instead of in form_for format.

We might want to add a checkbox when there are no results to have an option to be listed for remote pairing. This can be added later on if we have time since it means changes to the DB.

I can create a favicon from the logo to be used

I checked Heroku rails console and saw this user who has no data other than their GitHub login name. I wonder how she got in. I will email her via her email on GitHub.

http://www.codermatch.me/users/raysrashmi

Under comments.hbs, we want to replace user.name with user.login to link to their profile page. Currently, this won't work. If the user's name is their full name, the link to their profile won't pull the repo down.

We wouldn't add anything complicated since there are services that provide this already. But it might be a nice way to keep users connected to our site in the future if they have a simple tool like this. http://www.reddit.com/r/SideProject/comments/1j3skl/find_a_pair_programming_buddy_looking_for_beta/

[–]jabbajac 1 point 9 days ago
Totally! To me programming isn't something I need to sit next to someone for. If anything we're probably working on different portions of code at the same time. I've actually had a similar experience working with a roommate on a programming project over a break. We kept our code synced and then just kept in contact with email or messaging. I think that would be pretty cool for you guys to add some sort of messaging ability so partners can keep up with what the other is doing and maybe discuss new features as well.

Sometimes the words overlap

Comments links to user's name, so no repo is pulled:
http://localhost:3000/users/Stephane%20Bellity

Should be linked to GitHub login:
http://localhost:3000/users/Sbellity

img {
max-width: 100%;
}
as wide as the actual dimension of the image

background-size: cover; (same as 100%)

Setting a height in px is ok for images

grid: change everything to %
using ems

put media queries at the bottom of each section

do mobile first

600px and down = phone

800px and down = iPad

@media screen and (min-width: 600px) {
styles go here {
}
}

Styles 600px and up

Set border color to see where things are changing
border: 1px solid red;

No % for background image 'cuz it thinks nothing is there

config / initializers / secret_token.rb

Is there a way to set all 3 of us as remotable so people can pair with us remotely? Right now each time we find local people, we will be set to "false" for remotable.

Something to add down the road...

http://kamisama.github.io/cal-heatmap/

Data can be loaded remotely, and CSV, JSON, TSV, and plain text formats are supported. The API allows values to be highlighted, and the legend, cell size, and position are all configurable.

Inspired by: https://www.pingdom.com/

If I don't want to be emailed about comments on my wall, I should be able to click an option to turn notifications off.

Sometimes when we work on our own things, everything makes sense straight away, including to our teachers like Matt Buck and Keith. But it looks like many people who are new to the site need more description and guidance on what it's all about.

These two redditors asked some questions that would be good to answer on the index or maybe an about page.

[–]Scotty_Thomas 2 points 19 hours ago
This seems like an interesting idea, I'm down to help test and try it out. Curious to how it works since it doesn't clearly say how it works on the website?

[–]samnangchhun 1 point 10 hours ago
It's an interesting idea, but I don't see how it works yet? What will be different from Letspair or RubyPair?

Ask Stephane about if 'name' in event['data']['actor']['name'] correlates to 'name' column in user table or 'login' ... location is hull_event_handler.rb

        if user_login
          # OLD: event['data']['actor']['login'] didn't work - check with Stephane to make sure 'name' will always be login: value
          # Changed login: to name: and it works
          commenter   = User.where(name: event['data']['actor']['name']).first rescue nil
          content     = event['data']['object']['description'] rescue nil
          Notifications.delay.new_comment(recipient, commenter, content)

Later on if we have time

As a user, I want to be able to choose multiple languages to find other pair programmers and vice versa.

There should be a settings option for me to update my language and level.

As a user, I want to get an email when someone is ready to pair in my area or remotely.

This applies to searches with no results.

Hull.logout().then(function () {window.location = 'http://codermatch.me'});