jcarreon808 / alcoholoverflowfrontend Goto Github PK

Therre are API requests in a bunch of places in the code base. Refactor this into a single adapter or factory and then call ti from wherever

You sort them on the next line...so on this line that is a misleading variable name. I'd just make two variables.

In here you display both the most reviewed wine and the wine of the week. Couldn't you use the wine component and just pass in different wines here instead of having a few slightly different iterations on a wine display?

Had to do some serious hunting to find the :. Just extract this to a function and use a normal if statement. Similar to this: https://facebook.github.io/react/docs/conditional-rendering.html

Each component should be reusable. That means that having this component modify the DOM of a child component is not good. In addition to that, you shouldn't be modifying the DOM directly if you can avoid it due to the virtual DOM stuff. Instead reset state appropriately to clear out these variables.

So you do a fetch to get the details of a wine given a specific id. Then grab that to increment/decrement the upvotes. There is no need to do that intial fetch to get the wine details. You've already done by fetching all wine data. Instead of just passing in the id into this function you can pass the entire wine object in. That way all you need to do is do the PUT request.

they look to be identical every time? Why not just have one value

So you use this function to display the most reviewed wines, but the function itself doesn't do anything other than return a sorted version of the wines. A better function name would be just sortedWinesByReviews

This line can be made a bit simpler using map instead of that for loop. Any time you feel yourself making a blank array, then putting stuff into it there is usually an iterator you can use

So you slice the array to just have one thing in it. Then throughout the component you are doing mostreviewed[0] if you feel yourself doing that a lot, just when you slice, grab the 0th element right there.

These two occurrences plus the one above that sorts them is dying to be put into a function! Also I assume you want them to be sorted no matter the filter?

Put this into a normal site CSS

What actually will be in newAry? What is in data?

It's small, but it matters!