jbeyerstedt / kirby-widget-rsync_publishing Goto Github PK

Hello Jannik,

I needed to reconfigure this widget since somebody deleted the config. As a first test I did a dry-run to the secondary site and then a real deployment to the secondary site. But surprisingly the deployment happened to the primary(!) site. It may be caused by these lines of code:

<?php if ($get_param == 'test' || $get_param == 'secondary_test') : ?>  

<div class="dashboard-box">  
  <a class="dashboard-item" href="<?php echo panel()->site()->url() ?>/panel?widget_rsyncpublishing=run">

To my (little) understanding you fire the same link independent if the user did a dry run to the primary or secondary site. So I tweaked the code above to this:

<?php if ($get_param == 'test') : ?>

<div class="dashboard-box">
  <a class="dashboard-item" href="<?php echo panel()->site()->url() ?>/panel?widget_rsyncpublishing=run">
    <figure>
      <span class="dashboard-item-icon dashboard-item-icon-with-border"><i class="fa fa-exchange"></i></span>
      <figcaption class="dashboard-item-text"><?php echo $strings[$lang]['butt_publish'] ?></figcaption>
    </figure>
  </a>
</div>
<div class="dashboard-box">
  <a class="dashboard-item" href="<?php echo panel()->site()->url() ?>/panel/">
    <figure>
      <span class="dashboard-item-icon dashboard-item-icon-with-border"><i class="fa fa-backward"></i></span>
      <figcaption class="dashboard-item-text"><?php echo $strings[$lang]['butt_abort'] ?></figcaption>
    </figure>
  </a>
</div>

<?php elseif ($get_param == 'secondary_test') : ?>

<div class="dashboard-box">
  <a class="dashboard-item" href="<?php echo panel()->site()->url() ?>/panel?widget_rsyncpublishing=secondary_run">

I am not familiar with Github and have too much respect for your code, so please feel free to incorporate it into your code if you think this makes sense.

Yours, Yves

Just for better readability ;-)

Our latest Kirby project has around 400 pages for a single language. Therefore it takes quiet some scrolling to reach the end of the page to finalize the publishing run. Since the 400 pages take some time for the dry-run and the publishing it would be good to give some indication in the modal dialogue that something is happening.

So far for know and great plugin. THX a lot.

Hi Jannik,

our usual web server setup consists of three servers:

• a password protected development server
• a password protected preview server – e.g. for discussions with the client
• a public live server

So it would be great to have such an option:

c::set('rsync_publishing.previewsite_folder', preview_site');