jbesraa / oh-auth Goto Github PK
View Code? Open in Web Editor NEW:grimacing:
:grimacing:
Its good to try and tidy up things that you dont need as you go along otherwise its really easy to forget about them
https://github.com/esraajb/oh-auth/blob/master/src/routes.js#L5-L6
'Database built' is logged before the database is built. Perhaps change the message to 'Database building...' as 'Database is built' before the database has has a chance to be built
https://github.com/esraajb/oh-auth/blob/master/src/db_build.js#L19
I love the fact that you have separated your server logic and your database logic, but your naming for the byUserId/getUser/userQuery
function is confusing.
I think you should just call the function getUser
, the file should be called getUser.js
and you should require it in to your server.js
file as getUser
Also, it's quite a small point, but I think the signature for this function should be different.
If you look at the examples from the pg
module, their functions follow an argument convention with the cb as the last argument.
So instead of having getUser
as
const byUserId = (cb, userId) => {
I think it should be
const byUserId = (userId, cb) => {
header.html
and login.route.js
Create index.html
Create main.css
Create index.js
Create handlebars template
In velocity function on user_page.js
Wouldn't it be better to store these as integer
data type, rather than text
?
pie chart using google pie charts
list of closed issues
list of open issues
nav bar on top with page title
log out button/toggle in nav bar
You might want to take that out to a separate file, to leave only server settings in server.js
There is a lot of good logic inside of this size! Perhaps seperate the callbacks (initial post for access token, post for user info, and jwt-sign) into seperate files and require them in
Make this project look pretty!
You could use them here:
https://github.com/esraajb/oh-auth/blob/master/src/routes/user_page.js#L37
Can we have a quick check to see where we are and prioritise tasks to get our minimum viable product?
Create a basic homepage that has a button which will redirect to GitHub for you to log in.
Add title to page
{{!< layout/default}} should be {{!< layouts/default}}
Endpoints to create:
Is there a reason for this? Looks a bit funny.
https://github.com/esraajb/oh-auth/blob/master/src/routes.js#L10-L14
This should not be named 'token', this is just your parsed body
https://github.com/esraajb/oh-auth/blob/master/src/routes/results.route.js#L16
on line 19 token.accessToken is your token
Read GitHub API documentation to find specific queries
Find specific information from GitHub API for specific user.
A declarative, efficient, and flexible JavaScript library for building user interfaces.
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. ๐๐๐
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google โค๏ธ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.