jbedard / html-insert-assets Goto Github PK

View Code? Open in Web Editor NEW

7.0 7.0 5.0 912 KB

Insert assets such as .js, .css into an HTML file.

License: MIT License

JavaScript 0.20% CSS 0.04% HTML 0.13% TypeScript 99.63%

html-insert-assets's People

Contributors

Stargazers

Watchers

Forkers

alan-agius4 themacguffinman ztl8702 aghassi fannairu

html-insert-assets's Issues

Support for Manifests

I would like to use this package for a PWA.
Thus a --manifest argument would be really handy.

Example

--manifest manifest.webmanifest

should result in

<link rel="manifest" href="manifest.webmanifest" />

`async` is resolved as `async=""`

In the head of my html I have a link to a font like this

<link href="https://fonts.googleapis.com/css2?family=Roboto&display=swap" rel="stylesheet" async />

But after running html-insert-assets I get this as an output:

<link href="https://fonts.googleapis.com/css2?family=Roboto&amp;display=swap" rel="stylesheet" async="">

Not the difference of async. It is now async="". But it should just be async

support various stamp options (hash, lastmod, none)

support path replacements in addition to root paths

html5 doctype tag causes crash

Since the parse5 upgrade?

TypeError: treeAdapter.getChildNodes is not a function or its return value is not iterable
    at findElementByName (.../node_modules/html-insert-assets/dist/main.js:35:33)
    at findElementByName (.../node_modules/html-insert-assets/dist/main.js:36:24)
    at Object.main (.../node_modules/html-insert-assets/dist/main.js:297:18)
    at Object.<anonymous> (.../node_modules/html-insert-assets/dist/run.js:4:27)

support passing args with = instead of space between name/value

... this is sometime nicer when invoking the cli programatically, also seems to be semi-standard.

support directories of assets

make the leading slash configurable

when a base href is used than the injected js + asset file paths wont work. It always tries to
go to the main domain instead off the subfolder where the app is running

example:
domain.com/shop/app -> the injected paths with leading slash will show to domain.com/xxx.js instead of domain.com/shop/app/xxx.js.

support <script async>

Fails under docker. Most likely to fail under different distros.

I have been trying to understand why this package was not working. I have been getting an error when I put a statement into my docker file like this;

RUN html-insert-assets --out index.html --assets switch.css switch.js --verbose

It was giving an error;

/usr/local/bin/html-insert-assets: 1: /usr/local/bin/html-insert-assets: //: Permission denied /usr/local/bin/html-insert-assets: 3: /usr/local/bin/html-insert-assets: Syntax error: "(" unexpected

Turns out that the bin was pointed out to be src/main.js which does not include a shebang statement to tell how to interpret this binary which is the main reason for the error.

Feature request

Page load times can be decreased by preloading links: https://web.dev/uses-rel-preload/

Which can be added to the head of a document:

<head>
  ...
  <link rel="preload" href="styles.css" as="style">
  <link rel="preload" href="ui.js" as="script">
  ...
</head>

Would be cool to see something like this:

html-insert-assets
    --preload my.js my.css