jazzband / django-discover-jenkins Goto Github PK

I've just downloaded, installed pylint, discover_jenkins, discover_runner, and configured discover_jenkins according to docs. After I run:

python manage.py test --jenkins

I get results in reports/ but also warning notice after normal django tests:

Creating test database for alias 'default'...

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK
Destroying test database for alias 'default'...
[...]pylint/reporters/text.py:79: UserWarning: parseable output format is deprecated. This is equivalent to --msg-template={path}:{line}: [{msg_id}({symbol}), {obj}] {msg}  % (self.name, self.line_format))

It's pylint related...

My setup:
discover_jenkins 0.1.1
pylint 1.0.0,
astroid 1.0.0, common 0.60.0
Python 2.7.3 (default, Apr 10 2013, 06:20:15)
[GCC 4.6.3]

In PIP version of django-discover-jenkins there is no default pylint.rc in tasks folder as in Your source code. To change this you need to set TEST_PYLINT_RCFILE in settings.py:

TEST_PYLINT_RCFILE = '/path/pylint.rc'

Please add a CONTRIBUTING.md file to the repo that contains the snippet listed on https://jazzband.co/docs/guidelines#contributions to show to users opening issues or PRs what the contributing guidelines are.

We don't have anybody maintaining or using this project anymore. @camilonova would you like to take it over?

In 22754d4 the default runners were renamed, but the actual runners weren't renamed. This breaks the default config.

Instead of using inspect.getmembers and connecting all the signals that match the task methods, use hasattr like the Django request handler does for middleware. This is less magical, and doesn't need signals.

https://github.com/django/django/blob/stable/1.5.x/django/core/handlers/base.py#L63

So the high-level issue I want to resolve is to ignore test and migration files from the coverage report. The TEST_COVERAGE_WITH_MIGRATIONS flag isn't working for me (want_file from https://github.com/lincolnloop/django-discover-jenkins/blob/master/discover_jenkins/tasks/with_coverage.py#L93-L94 is never being executed for me because the measured_files list comes in empty anyways), which is okay, because I was planning on using the coverage.rc file anyways.

The problem with that is that the omit is being ignored

https://github.com/lincolnloop/django-discover-jenkins/blob/master/discover_jenkins/tasks/with_coverage.py#L78-L85

It appears that what's happening is that coverage is first processing the config_file, which properly sets the omits. Then, it reads the omit kwarg passed in, which, in my case, is empty. This, however, overwrites it, so it doesn't omit anything.

My current workaround is to put the omits as the folders setting, though the naming is a little strange (though the implementation works):

TEST_COVERAGE_EXCLUDES_FOLDERS = [
        '*/migrations/*',
        '*/tests.py',
        '*/test_*.py',
    ]

So the right affordances are in here to make it work, though it did take me some digging to figure out. I would be glad for a fix for the coverage.rc file to be honored in its entirety, but I would also be happy to just see a caveats in the documentation that omit in the coverage.rc file will be ignored and to use the other settings.

Let me know if I can provide any other information or help on this.

It should be using the built-in ignore pattern from the staticfiles app, but this doesn't seem to be working for some reason.

The original django-jenkins tests are here:

https://github.com/kmmbvnr/django-jenkins/tree/master/tests