jayfoxrox / citra Goto Github PK

specular_sum.rgb += (((1.000000 * texture(lut[0], ((FLOAT_255 * ((clamp(dot(normal, normalize(normalize(view) + light_vector)), -1.0, 1.0) < 0) ? clamp(dot(normal, normalize(normalize(view) + light_vector)), -1.0, 1.0) + 2.0 : clamp(dot(normal, normalize(normalize(view) + light_vector)), -1.0, 1.0)) / 2.0)))[0]) * light_src[1].specular_0) + ((1.000000 * texture(lut[0], ((FLOAT_255 * ((clamp(dot(normal, normalize(view)), -1.0, 1.0) < 0) ? clamp(dot(normal, normalize(view)), -1.0, 1.0) + 2.0 : clamp(dot(normal, normalize(view)), -1.0, 1.0)) / 2.0)))[1]) * refl_value * light_src[1].specular_1)) * 1.0 * 1.0;

Yeah.. no.. thanks

Can be fixed by GL_CLAMP_TO_EDGE on LUT entries. why tho?

Maybe wraparound near 0.0? (Shader lookup is restricted to [0.0, 255.0/256.0])

See discord conversation with Migue

Why?

I had 600+ shaders within seconds. Is this normal?

There should be a debugger for the Pica combiner which will work similar to the shader debugger.
It should be possible to see triangles (either highlighting it in the main window or another view) and to get formulas for every pixel processed including intermediate results.

This would probably be more useful if the Resume button in the pica viewer could step forward a given number of breakpoints and / or select a specific triangle in this debugger

Angry Birds: Trilogy

Basically the game will crash upon booting.

HW.GPU <Critical> video_core\shader\shader_jit_x64.cpp:Pica::Shader::JitShader::Compile_NextInstr:803: Unhandled instruction: 0x23 (0x8d86c00f)
HW.GPU <Critical> video_core\shader\shader_jit_x64.cpp:Pica::Shader::JitShader::Compile_NextInstr:803: Unhandled instruction: 0x23 (0x8dffc36c)
HW.GPU <Critical> video_core\shader\shader_jit_x64.cpp:Pica::Shader::JitShader::Compile_NextInstr:803: Unhandled instruction: 0x20 (0x8000036e)
Debug <Critical> video_core\shader\shader_jit_x64.cpp:Pica::Shader::JitShader::Compile_NextInstr::<lambda_8b3a2e9a55548d22ec356b62350b6fb1>::operator ():789: Assertion Failed!
Tried to compile already compiled shader location!

Although the game will run if Shader JIT is turned off.

This game boots in the latest master without the aforementioned issue.
Therefore, this is a regression.

I have the feeling this will be merged soon and GUI was always a trouble-maker in the past.
I should run it locally and test how it behaves / influences debugging etc.

Super Mario 3D Land looks glitched (aside from the broken effects from imm-mode2) in S6-5 and probably the other levels in sw-rasterizer. Pillars are visible through platform.

Without fix-batching (hw on top and sw below)
With fix-batching (hw on top and sw below)
Without fog in sw-rasterizer.

The first save file is right on S6-5. Rename to 00053F00 if using European version.
00054000.zip

Note to self: Can be fixed by disabling fog on logic ops..

I've talked to yuriks about this via IRC sometime in late april or early may.
This is important for mario kart, mario world and probably more.

I had a PR for this but it was pretty bad. Probably better to use vertex cache clear or something to do remaining draw calls?!

Subv said it's not that important. I still should do it, especially as he'll work on some todos which might introduce new bugs.

See fix-rotation branch or PR 1813

skycom code has a ton of rotations/shifts past width of type.

Looks like MSVC is not happy with my style.

Warnings and errors = should be using appveyor for this repo.

Link to PR citra-emu#1634

This was rejected because review took to long (due to Fix12P4 being incomplete), so I decided to abandon it.
I think it was actually complete and working for some time.

TODO:

• Rebase
• Possibly make it slimmer

Luigi's Mansion Dark Moon crashes when trying to boot.

[ 280.076043] Debug <Critical> video_core\command_processor.cpp:Pica::CommandProcessor::WritePicaReg::<lambda_c78dfa2ac9fb41a4dd6e808628d4f507>::operator ():431: Assertion Failed!
fog_lut_offset exceeded maximum value of 127!

Take over the old PR citra-emu#1263

SM3DL crashes with unsupported lighting mode for me

[ 238.317429] HW.GPU <Critical> video_core/renderer_opengl/gl_shader_gen.cpp:operator():402: Unknown lighting LUT input 5

causes

[ 238.319899] Debug <Critical> video_core/renderer_opengl/gl_rasterizer.cpp:operator():930: Assertion Failed!
Uniform block size did not match!

=> assert failed => exit

No idea why. See discord conversation with Migue

Current state of that repo makes me look like an idiot.. (thanks Obama MSVC)

I should probably create my own appveyor account or look for windows VMs, maybe rethink the concept altogether