Code Monkey home page Code Monkey logo

jukebox-pmmp's Introduction

[HitCount] Discord server

JukeBox-pmmp

A small plugin that implements the Jukebox and Records untill its in the core of pmmp !

IMPORTANT INFO:

For this plugin to function as intended, all mobile device users must download the 90mb DLC 'Music' free from the store in game (It is a one time download). (Please do not make issues saying theres no sound, there is but you have to have the dlc)

Special Thanks:

Thanks to the below for helping me testing in private, your help was massively appreciated.

Notice:

This is a freelance project and will not be constantly worked on, i do accept PR's and Feature requests though.

jukebox-pmmp's People

Contributors

jaxkdev avatar poggit-bot avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar

Forkers

madeaja

jukebox-pmmp's Issues

[BUG] Tile not created when not placed by player

Describe the bug clearly
When a jukebox is placed by anything over then a player when attempting to interact (&break) it will crash as a tile does not exist with it.

To Reproduce

  1. Use a outside plugin eg WorldEdit to place a jukebox
  2. Tap/break the jukebox

Expected behavior
Be able to interact successfully with the jukebox in every manor

Screenshots/Videos
image0

Server Host (please complete the following information):

  • OS: All
  • PMMP-Version 3.0.0->3.6.3
  • Plugin Version All commits after tile rewrite.

Client Device (please complete the following information, if applicable):

  • Device: All
  • MC Version: 1.9.0

Additional context
Tiles not being created/stored correctly.

[BUG] JukeBox wont eject after certain distance travelled

Hello, when i put a record on a jukebox, it's working perfecly but After ~10s of playing music, i can't drop the record. If i break the jukebox the music won't stop

And only players on W10 can hear the music. If you're on Android or iOS you can't.

[FEATURE] API & Events

Brief description:

Mostly aimed at adding new events useful for other plugins to be able to cancel and add even more custom configurations.

Proposed Methods (Events):

BaseEvent():

  • RecordPlayingEvent(Item $record, Block $jukebox, Player $player = null)
  • RecordStopEvent(Block $jukebox, Player $player = null)
  • JukeboxPlacedEvent(Block $jukebox, Player $player = null)
  • JukeboxDestroyEvent(Block $jukebox, Player $player = null)

Todo List:

  • Add new base event extended by all other internal plugin events.
  • Add base events (See above methods for list)
  • Call events and use data from events (possibly changed data from plugins)
  • Test all events using a external plugin.

after restart error in console

hi
i need always stop and start my server to restart. this is why with restart i become this error.

2020-08-01 [09:50:12] [Server thread/INFO]: Lädt JukeBox v1.0.2
2020-08-01 [09:50:12] [Server thread/CRITICAL]: RuntimeException: "Trying to overwrite an already registered block" (EXCEPTION) in "src/pocketmine/block/BlockFactory" at line 370
2020-08-01 [09:50:12] [Server thread/CRITICAL]: #0 plugins/JukeBox-pmmp_dev-23.phar/src/Jackthehack21/JukeBox/Main(58): pocketmine\block\BlockFactory::registerBlock(object Jackthehack21\JukeBox\Block\JukeBox, boolean )
2020-08-01 [09:50:12] [Server thread/CRITICAL]: #1 plugins/JukeBox-pmmp_dev-23.phar/src/Jackthehack21/JukeBox/Main(43): Jackthehack21\JukeBox\Main->registerItems()
2020-08-01 [09:50:12] [Server thread/CRITICAL]: #2 src/pocketmine/plugin/PluginManager(182): Jackthehack21\JukeBox\Main->onLoad()
2020-08-01 [09:50:12] [Server thread/CRITICAL]: #3 src/pocketmine/plugin/PluginManager(346): pocketmine\plugin\PluginManager->loadPlugin(string[84] C:\Users..........\Desktop\PocketMine-MP-minigames-hub\plugins\JukeBox-pmmp_dev-23., array[2])
2020-08-01 [09:50:12] [Server thread/CRITICAL]: #4 src/pocketmine/Server(1854): pocketmine\plugin\PluginManager->loadPlugins(string[60] C:\Users............\Desktop\PocketMine-MP-minigames-hub\plugins)
2020-08-01 [09:50:12] [Server thread/CRITICAL]: #5 src/pocketmine/command/defaults/ReloadCommand(49): pocketmine\Server->reload()
2020-08-01 [09:50:12] [Server thread/CRITICAL]: #6 src/pocketmine/command/SimpleCommandMap(248): pocketmine\command\defaults\ReloadCommand->execute(object pocketmine\command\ConsoleCommandSender, string[6] reload, array[0])
2020-08-01 [09:50:12] [Server thread/CRITICAL]: #7 src/pocketmine/Server(1811): pocketmine\command\SimpleCommandMap->dispatch(object pocketmine\command\ConsoleCommandSender, string[6] reload)
2020-08-01 [09:50:12] [Server thread/CRITICAL]: #8 src/pocketmine/Server(1423): pocketmine\Server->dispatchCommand(object pocketmine\command\ConsoleCommandSender, string[6] reload)
2020-08-01 [09:50:12] [Server thread/CRITICAL]: #9 vendor/pocketmine/snooze/src/SleeperHandler(123): pocketmine\Server->pocketmine{closure}()
2020-08-01 [09:50:12] [Server thread/CRITICAL]: #10 vendor/pocketmine/snooze/src/SleeperHandler(85): pocketmine\snooze\SleeperHandler->processNotifications()
2020-08-01 [09:50:12] [Server thread/CRITICAL]: #11 src/pocketmine/Server(2157): pocketmine\snooze\SleeperHandler->sleepUntil(double 1596271811.9429)
2020-08-01 [09:50:12] [Server thread/CRITICAL]: #12 src/pocketmine/Server(1994): pocketmine\Server->tickProcessor()
2020-08-01 [09:50:12] [Server thread/CRITICAL]: #13 src/pocketmine/Server(1588): pocketmine\Server->start()
2020-08-01 [09:50:12] [Server thread/CRITICAL]: #14 src/pocketmine/PocketMine(273): pocketmine\Server->__construct(object BaseClassLoader, object pocketmine\utils\MainLogger, string[52] C:\Users........\Desktop\PocketMine-MP-minigames-hub, string[60] C:\Users......\Desktop\PocketMine-MP-minigames-hub\plugins)
2020-08-01 [09:50:12] [Server thread/CRITICAL]: #15 src/pocketmine/PocketMine(304): pocketmine\server()
2020-08-01 [09:50:12] [Server thread/CRITICAL]: #16 (11): require(string[107] phar://C:/Users/...../Desktop/PocketMine-MP-minigames-hub/PocketMine-MP.phar/sr)
2020-08-01 [09:50:12] [Server thread/CRITICAL]: Konnte Plugin 'JukeBox' nicht laden

Custom Records

pretty cool if we can have a disc and it plays a nbs file

[BUG] 2 Bugs

I hope this is a good issue:

I can't set the juke boxes, and when I set them via WorldEdit and klick on them with a vinyl record "Internal Server Error" and that is in the console:

[17:33:04] [Server thread/CRITICAL]: Error: "Call to a member function handleInteract() on null" (EXCEPTION) in "plugins/JukeBox-pmmp_dev-14.phar/src/Jackthehack21/JukeBox/Block/JukeBox" at line 59

PmmP Version: 3.6.4
OS: Linux
Plugin Version: Version 1.0.0

Infinite Music Play

Infinite Music Play

Hi, I am a frequent user of your plug-in.
I'm going to tell you what I want to do to improve this plug-in.
The function I want is to play music infinitely.
It's too much of a hassle to change the record again when the song is finished. Please set the song to repeat in the config.
I am Korean and I am speaking using a translator. Please say the words in the comments that you don't understand.

[BUG] Cant set Juke Boxes, and a bug!

I can't set the juke boxes, and when I set them via WorldEdit and klick on them with a vinyl record "Internal Server Error" and that is in the console:

[17:33:04] [Server thread/CRITICAL]: Error: "Call to a member function handleInteract() on null" (EXCEPTION) in "plugins/JukeBox-pmmp_dev-14.phar/src/Jackthehack21/JukeBox/Block/JukeBox" at line 59

Question

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]no

Describe the solution you'd like
A clear and concise description of what you want to happen.
If I use a resource pack and change the music wil the music be different

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.
Link of what I mean https://youtu.be/FWPiSKsseb0

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.