javidpack / census Goto Github PK

Trying to set a home for a modded NPC via housing menu just sets the Guide's house instead. Currently on tMod v 11.1 with Census, CheatSheet, Thorium, and Auto trash.

According to the 1.4.4 changes, "NPCs who die will now respawn freely, ignoring the original unique conditions which were required to spawn in the first place."

https://terraria.wiki.gg/wiki/1.4.4

Need to figure out how that is implemented, make sure the indicators are correct, and possibly see if tModLoader needs changes.

Could you possibly add a config option to disable the conditions required text? I know this defeats half the purpose of the mod, but I just thought it might be nice to have the option to know all the NPCs you need to get, but not see how to get them.

Report https://discord.com/channels/276235094622994433/562193889046429698/1185255024637526036

I think there is a distinction between spawn conditions and housing conditions, not sure if or how that would be communicated.

TownNPCInfo and Mod.Call should use LocalizedText so localization can be supported

As the NPC's listed who are currently living in the world have a red background, I suggest you replace the cross and tick system with coloured backgrounds, keeping it consistent.

Would be interesting to hide NPC's who are beind a mandatory progression lock to compromise between the current census and vanilla (WOF, Mechs, Planterra, Golem, ML). (Possibly config option?)

npc's at the 'inbetween' of moved in and not moved in are overlayed and neither are usually legible due to the words overlapping.

EDIT: changing ui scale by 1% seems to fix it... but i dont really understand why i should have to do that in the first place

Mod's in-game description incorrectly states that the Dryad will move in after any boss has been defeated, without mentioning that pre-EOC bosses do not trigger this. This is liable to cause some confusion in the early game, especially when you factor in mods that add more bosses to this stage in the game.

Excerpt from the wiki:

The Dryad is an NPC vendor that will spawn once the following criteria have been met:

There is an empty house.
The Eye of Cthulhu, Eater of Worlds, Brain of Cthulhu, Skeletron, or Lepus(3DS) has been defeated.

"just letting you know that these instructions are outdated: https://forums.terraria.org/index.php?threads/census-town-npc-checklist.74786/#post-1675157
aswell as the actual 1.4 mod description still using mod.NPCType("string") https://steamcommunity.com/sharedfiles/filedetails/?id=2687866031&searchtext=census "

Suggestions from https://forums.terraria.org/index.php?threads/census-town-npc-checklist.74786/page-3#post-3116084

I guess they want either actual happiness values or the things that raise or lower happiness. Probably too much work to do.