javasync / rxio Goto Github PK

Bad use here: https://github.com/javasync/AsyncFileRw/blob/master/src/main/java/org/javaync/io/AsyncFileReader.java#L81

We cannot assume that we have a valid number of bytes: res.append(new String(bytes, UTF_8));

This can be wrong: new String(bytes, UTF_8)

I think NewlineIterator is useless.

Check this: https://stuartmarks.wordpress.com/2020/04/14/scanner-is-a-weird-but-useful-beast/

This method was intended for an unbounded Observable without backpressure. Thus we should implement it based on Observable of RxJava rather than Publisher. And then maybe latter we may convert it to a Flowable (a Rx Java implementation of Publisher) with a BackpressureStrategy.BUFFER strategy.

This looks to work fine:

Flow.Publisher<ByteBuffer> body = BodyPublishers.ofFile(metamorphosis);
Observable
    .fromPublisher(FlowAdapters.toPublisher(body))
    .take(10)
    .map(buf -> new String(buf.array()))
    .zipWith(Observable.interval(500, TimeUnit.MILLISECONDS), (item, interval) -> item)
    .subscribe(str -> System.out.println(str));
System.out.println("Subscribed");