Code Monkey home page Code Monkey logo

Comments (47)

iliakan avatar iliakan commented on May 24, 2024 2

Please take a look at https://es.javascript.info/

from es.javascript.info.

EzequielCaste avatar EzequielCaste commented on May 24, 2024 1

from es.javascript.info.

iliakan avatar iliakan commented on May 24, 2024 1

@EzequielCaste sorry, my typo, now should work =)

from es.javascript.info.

iliakan avatar iliakan commented on May 24, 2024 1

Please translate this:

es.yml.zip

from es.javascript.info.

iliakan avatar iliakan commented on May 24, 2024 1

@joaquinelio what's wrong with the last line? It just states that the Spanish version is a translation of the English one.

By the way, do you know that you can translate text in images too?
For example, here:
image

We use SVG format for images, so no need to use graphics editor for that. Just translate the text.
Here are the details: https://github.com/javascript-tutorial/server#translating-images

from es.javascript.info.

iliakan avatar iliakan commented on May 24, 2024 1

Please also check out https://es.javascript.info/about

from es.javascript.info.

iliakan avatar iliakan commented on May 24, 2024

Yeah, let's do that! =)

Please translate these YAML files (engine localizations for Spanish):

locales.zip

(Unzip, translate the phrases and zip again, keeping the structure).

from es.javascript.info.

EzequielCaste avatar EzequielCaste commented on May 24, 2024

Ok great!
I'm working on it 👍

from es.javascript.info.

EzequielCaste avatar EzequielCaste commented on May 24, 2024

locales.zip

Done! 🎉

from es.javascript.info.

joaquinelio avatar joaquinelio commented on May 24, 2024

I'll start a big pull from EN.

maints, I'll leave ya this, click the delousing monkey:
articles left, date claimed
https://joaquinelio-zone17.glitch.me/

wishing many young folks learning here...

from es.javascript.info.

iliakan avatar iliakan commented on May 24, 2024

I enabled CI, so any pushes to this repo get to the site automatically.

from es.javascript.info.

iliakan avatar iliakan commented on May 24, 2024

I'm also going to add translation leads to the page https://es.javascript.info/about

BTW, is it true? @vplentinax did more than 50% of the translation?

from es.javascript.info.

EzequielCaste avatar EzequielCaste commented on May 24, 2024

@vplentinax she did the sincronization of the old translated files to the newer versions. Updating old translations.

I hope contributors names were not lost in the process.

from es.javascript.info.

iliakan avatar iliakan commented on May 24, 2024

The contributor for each line is tracked by git. You must have heard about the git blame command.

Usually it's reliable. But if an operation forces git to recognize the file as a new one, then the authorship for all lines is updated to the committer.

That's probably what has happened. Definitely not good.

from es.javascript.info.

EzequielCaste avatar EzequielCaste commented on May 24, 2024

BTW, I've changed my username in Github from ezzep66 to EzequielCaste. Is is possible to update it in the about page?

from es.javascript.info.

iliakan avatar iliakan commented on May 24, 2024

To fix that, an article should be fully recommitted, right now (late evening) no bright ideas about that, maybe you can suggest something?

@EzequielCaste the author details are almost impossible to change without recommitting. The author info is stored in Git repo, not on github (that's just a wrapper around Git). It's a part of the commit hash.

from es.javascript.info.

joaquinelio avatar joaquinelio commented on May 24, 2024

The contributor for each line is tracked by git. You must have heard about the git blame command.

Usually it's reliable. But if an operation forces git to recognize the file as a new one, then the authorship for all lines is updated to the committer.

That's probably what has happened. Definitely not good.

"Blame" should be useful, but it is nearly empty for many files here. I didn't care too much.
But.
I wonder if this is what causes a problem I'm dealing with now.
Pulling from English upstream tries to OVERWRITE SOME traslated files. NO conflicts shown.
I CAN'T TRUST IT! We need a trustworthy sync method, we shouldnt do it manually with our eyes.

I have 3 remotes, origin, upstrem (es) enstream (en)
merge upstream, ok
then
merge enstream, lots of conflicts, ok
but some files are replaced by english version with no conflict at all

D:\js\es.javascript.info\1-js\99-js-misc\04-reference-type\3-why-this\task.md
D:\js\es.javascript.info\1-js\99-js-misc\04-reference-type\3-why-this\solution.md

task.md , ok - (cant remember, either goes staged or shows conflict, but it IS OK).
solution.md - goes straight to the merge like no 3way is there.

I'm a novice on git. Coudnt find any useful from git log
I guess I'll put an issue?

from es.javascript.info.

joaquinelio avatar joaquinelio commented on May 24, 2024

LOVE IT ❤️

  1. Yes, Valentina vplentinax DID A LOT. She pushed the repo ahead, translations and reviews.

  2. I like this too
    According to your browser headers, you know English. Please help to translate the tutorial. Thank you!

We could use some new blood

  1. "about"
    HEY! Don't encourage TRANSLATORS only.
    we need REVIEWERS, the hard part.
    But it's ok, I was chasing people with solid background among them. It payed well. The site is a beauty.

I can die now. ✌️

from es.javascript.info.

iliakan avatar iliakan commented on May 24, 2024

Pulling from English upstream tries to OVERWRITE SOME traslated files. NO conflicts shown.
but some files are replaced by english version with no conflict at all

@joaquinelio I think I saw it too once, but don't remember what's causing it. I'd like to check out an example.

from es.javascript.info.

EzequielCaste avatar EzequielCaste commented on May 24, 2024

I enabled CI, so any pushes to this repo get to the site automatically.

Merged an article yesterday: Capturing groups #345

Online version has not been updated. Does this take some time? or is the update automatic?

from es.javascript.info.

EzequielCaste avatar EzequielCaste commented on May 24, 2024

Thank you @iliakan 🙏
One last favor I ask from you today...

since I changed my username, the Issue #17 Information gets overwritten:

Maintainer List
@lizzie136, @vplentinax, @ezzep66, @joaquinelio, @maksumi

can you please update my data?
I think the bot overwrites with original username, it should be @EzequielCaste

from es.javascript.info.

iliakan avatar iliakan commented on May 24, 2024

Done. Added maintainers at https://es.javascript.info/about =)

from es.javascript.info.

joaquinelio avatar joaquinelio commented on May 24, 2024

ok I'm on it. ✍️

from es.javascript.info.

joaquinelio avatar joaquinelio commented on May 24, 2024

Last line: "tutorial -is- English"?

hey pals: @EzequielCaste , @maksumi

dash - ¿","? Not natural. Not happy. Queda un poco forzado.
maintainer ... == ¿Mantenedor? prefero el título github!
markup ... ==
es.yml.zip

from es.javascript.info.

iliakan avatar iliakan commented on May 24, 2024

@joaquinelio is the es.yml.zip from your message a finished translation? or I'd better wait?

from es.javascript.info.

joaquinelio avatar joaquinelio commented on May 24, 2024
  1. SVG,
    I know that, I read about tha yaml in the server readme. It's Sad magicimg (or something) is not working for me yet. I'm dealing with the pull issue now.

Edit: Wow. That example DESERVES translation. I guess I'll look at it. Maybe just a missing path.

  1. yaml Last line
    "This is the translated version of the tutorial is English"
    sound odd

  2. to wait or not to wait...
    It depends.
    Nothing too wrong, it's good enough.
    But It doesnt seem urgent, no need to waste time, just a check.

from es.javascript.info.

iliakan avatar iliakan commented on May 24, 2024
  1. Maybe I should rephrase it?
  2. Ok, I'll wait then.

from es.javascript.info.

joaquinelio avatar joaquinelio commented on May 24, 2024
  1. Maybe I should rephrase it?

This is the translated version of the tutorial -in- English, maybe?
Again, not my language.

from es.javascript.info.

iliakan avatar iliakan commented on May 24, 2024

Oh, a typo there! Right, corrected 🙄

from es.javascript.info.

iliakan avatar iliakan commented on May 24, 2024

Thank you so much.

from es.javascript.info.

iliakan avatar iliakan commented on May 24, 2024

Now I feel stupid for not understanding you.

from es.javascript.info.

joaquinelio avatar joaquinelio commented on May 24, 2024

Says the man who created this entire multi-soul project

But it's ok, nobody understands me.
👍

from es.javascript.info.

EzequielCaste avatar EzequielCaste commented on May 24, 2024

We use SVG format for images, so no need to use graphics editor for that. Just translate the text.
Here are the details: https://github.com/javascript-tutorial/server#translating-images

Hi @iliakan I'm trying to install the server, following the instructions above, I get this error after the command edit es

[11:01:52] 'webpack' errored after 4.28 s
[11:01:52] ValidationError: Invalid options object. Copy Plugin has been initialized using an options object that does not match the API schema.
 - options[0] misses the property 'patterns'. Should be:
   [non-empty string | object { from, to?, context?, globOptions?, toType?, force?, flatten?, transform?, cacheTransform?, transformPath?, noErrorOnMissing? }, ...] (should not have fewer than 1 item)
 - options[1] misses the property 'patterns'. Should be:
   [non-empty string | object { from, to?, context?, globOptions?, toType?, force?, flatten?, transform?, cacheTransform?, transformPath?, noErrorOnMissing? }, ...] (should not have fewer than 1 item)
    at validate (C:\Users\ezzep\js\server\node_modules\copy-webpack-plugin\node_modules\schema-utils\dist\validate.js:96:11)
    at new CopyPlugin (C:\Users\ezzep\js\server\node_modules\copy-webpack-plugin\dist\index.js:24:30)
    at Object.module.exports [as webpack] (C:\Users\ezzep\js\server\modules\config\webpack.js:316:7)
    at Promise (C:\Users\ezzep\js\server\tasks\webpack.js:7:36)
    at new Promise (<anonymous>)
    at module.exports (C:\Users\ezzep\js\server\tasks\webpack.js:6:9)
    at C:\Users\ezzep\js\server\modules\engine\gulp\requireModuleTasks.js:11:12
    at taskWrapper (C:\Users\ezzep\js\server\node_modules\undertaker\lib\set-task.js:13:15)
    at bound (domain.js:425:14)
    at runBound (domain.js:438:12)
    at asyncRunner (C:\Users\ezzep\js\server\node_modules\async-done\index.js:55:18)
    at processTicksAndRejections (internal/process/task_queues.js:79:9)
[11:01:52] 'edit' errored after 4.28 s

Any thoughts how to solve this?

from es.javascript.info.

iliakan avatar iliakan commented on May 24, 2024

Please show me the versions:

cat node_modules/webpack/package.json | grep '"version"'
cat node_modules/copy-webpack-plugin/package.json | grep '"version"'

from es.javascript.info.

EzequielCaste avatar EzequielCaste commented on May 24, 2024

"version": "4.44.1", "version": "6.0.3"

from es.javascript.info.

iliakan avatar iliakan commented on May 24, 2024

That's strange: package.json has "copy-webpack-plugin": "^4.5.2".
So it really should be 4, not 6.

from es.javascript.info.

EzequielCaste avatar EzequielCaste commented on May 24, 2024

Ok rolled back to original version. I may hay updated the version..

Module build failed (from ./node_modules/mini-css-extract-plugin/dist/loader.js): ModuleBuildError: Module build failed (from ./node_modules/css-loader/dist/cjs.js): Error: Can't resolve '/img/subscribe_bg.svg' in 'C:\Users\ezzep\js\server\tmp\en'

from es.javascript.info.

EzequielCaste avatar EzequielCaste commented on May 24, 2024

Module execa was missing from my modules...

It's working now, at least on my localhost.

from es.javascript.info.

EzequielCaste avatar EzequielCaste commented on May 24, 2024

ok almost got it...

/article/coding-style/code-style.svg: Could not execute GraphicsMagick/ImageMagick: identify "-ping" "-format" "{"width":%w,"height":%h}" "C:\Users\ezzep\js\server\public\en\article\coding-style\code-style.svg" this most likely means the gm/convert binaries can't be found

from es.javascript.info.

joaquinelio avatar joaquinelio commented on May 24, 2024

@EzequielCaste

Welcome to the point I quit!
I guess it lacks PATH entry

Can you please check es.yml.zip from... uhm... comment 5 hours before this?
Plis don't drop the entire transl...

es.yml.zip
original
10 hours before this...

it really should show the comment ID

from es.javascript.info.

maksumi avatar maksumi commented on May 24, 2024

Last line: "tutorial -is- English"?

hey pals: @EzequielCaste , @maksumi

dash - ¿","? Not natural. Not happy. Queda un poco forzado.
maintainer ... == ¿Mantenedor? prefero el título github!
markup ... ==
es.yml.zip

Ponme en contexto @joaquinelio

from es.javascript.info.

joaquinelio avatar joaquinelio commented on May 24, 2024

@iliakan
Well, no reviewers for this.
It's ok, you can use it. Some changes from the last one.

es.yml.zip

Anything else to be done here?

from es.javascript.info.

EzequielCaste avatar EzequielCaste commented on May 24, 2024

Sorry @joaquinelio I didn't quite understand what you meant. 🤷‍♂️

We're you waiting for me to review this?

from es.javascript.info.

EzequielCaste avatar EzequielCaste commented on May 24, 2024

Closing this, since we are ONLINE now and I was able to translate the SVG images.

from es.javascript.info.

joaquinelio avatar joaquinelio commented on May 24, 2024

new issue?
es.js.cx’s server IP address could not be found.

//es.javascript.info/event-delegation

2.2.3 article.md (still English)
line 14 [iframe height=350 src="bagua" edit link]

buttons:
plunker is working
new window is not: //es.js.cx/article/event-delegation/bagua/

from es.javascript.info.

iliakan avatar iliakan commented on May 24, 2024

Should be ok now, is it?

from es.javascript.info.

joaquinelio avatar joaquinelio commented on May 24, 2024

that was fast 👍

from es.javascript.info.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.