jasonsanford / google-vector-layers Goto Github PK

gvector.A2E extends gvector.AGS. We'll need a new class in the documentation.

There's lots of crazy stuff Esri supports, but I think we can probably support esriSMSCircle

Some Documentation on EsriSMS symbols

With AGS layers we can simply throw in 1=1 as a where parameter to return all features. This doesn't work with A2E.

Almost there. Needs more testing.

We should have layerBounds as an option. If a map is panned or zoom outside of this bounds, no more feature requests are made.

var myAGSLayer = new vectors.AGS({
    url: "http://my-arcgis-server.com/arcgis/rest/services/schools/mapserver/10"
    fields: "*",
    uniqueField: "OBJECTID",
    layerBounds: new google.maps.LatLngBounds(new google.maps.LatLng(34, -80) /* SoutWest */, new google.maps.LatLng(36, -78) /* NorthEast */)
});

We currently only support Point, LineString, MultiLineString and Polygon.

Need to support MultiPoint and MultiPolygon as well.

We should return an error JSON object if there was a problem creating the vector layer. Something like:

{
    "error": true,
    "message": "A \"url\" parameter is required when creating an ArcGIS Server Layer."
}

Then a user could easily check to see if there was an issue creating the layer:

var myAGSLayer = new vectors.AGS({
    aBadOption: "oops",
    uniqqueField: "spelled unique wrong"
});

if (myAGSLayer.error){
    // Handle error
}else{
    myAGSLayer.setMap(myMap);
}

These two methods aren't camel cased the same way and one includes the word geometry. A little confusing.

Yelp's API supports bounding box searches. This would be fun to add, not sure it's worth the extra KB though.

This is already there for AGS layers.

If the "showAll" parameter is true then all features are requested immediately instead of after each pan or zoom. The would be beneficial for datasets with tens of features that can be easily downloaded and rendered all at once.

default would be false

This is a handy way to reduce the number of vertices returned for all around better performance.

Sometimes feature requests take a long time to return and the user could have already turned this layer off. We should initially check for this.options.map when we start to process features.

None of the layers have where documented. How did this slip through?

Something funky is happening to the sub-layer checkboxes like terrain and labels. I suspect bootstrap.css is to blame.

I have a sneaking suspicion infoWindowContent isn't being reset if a feature's attributes change. Worth a check later.

I think I remember Esri's REST API having some symbology declarations built in.

A spatial extension for CouchDB, GeoCouch supports bbox searches which make it a candidate for a new layer type.

It would be good to have a GeoCouch instance to use for demos. I think PDX API, created by @maxogden would work.

Requested in #16.

Google assumes all icon's anchor points are at the bottom center of the image. Typically Esri marker icons aren't modeled after a pushpin like Google. We'll need to read the esriOptions JSON to create a custom marker to get better results.

Specifically look for symbol.xoffset and symbol.yoffset.

There should be working code over at JasonSanford/leaflet-vector-layers to do this.

Not sure what's up with this.

If the infoWindowTemplate parameter is true, a google.maps.InfoWindow is shown with the feature's info when it is clicked.

A2E for instance @ e674ec5

This is the method to check if geometry has changed for dynamic layers. Right now it's just a placeholder.

It's not clear how to use the esriOptions parameter for gvector.AGS. This should be added to the docs.

This is just a placeholder for now. We should make this set the options passed in the function variable.

It would be quite easy to add new geoweb service providers to what's here currently (AGS, A2E, GeoIQ). Some other options are:

• Google Fusion Tables - do they allow bbox searches or can you just use FT through the GMaps API?

I've brought the issue up here.

The root for these is at /index.html as it will be served as a submodule of my GitHub pages hosted blog, probably something like http://geojason.info/google-vector-layers/

These should be in their own files so that people who build without AGS don't need the _esriJsonGeometryToGoogle method and likewise with other layers which use the _geoJsonGeometryToGoogle method (GeoIQ, CartoDB).

I'm finding lots of places where I'm repeating code (with slight variations for different providers). I'm tired of rewriting code 4 times.

There should be a getting started page to let user know exactly what is needed to use this library and maybe how to build a custom library without certain layers.

Currently useing gvector-include.js for ease of debugging.

If we're symbolizing on a speed attribute and the speed of a feature goes from 15 to 25, the symbology doesn't get changed. It needs to.

It's sometimes annoying to close a bunch of infoWindows. This option would have a single infoWindow for the layer that would close and open when you clicked a different feature.

CartoDB - PostGIS based hosted web services that support bbox search and GeoJSON output

As suggested at #16, add support for MapFish protocol. The data will need to be (I think) in the WGS 84 Lat/Lng reference system (SRID 4326).

I'm not sure why.

I'm using jQuery's .getJSON (.ajax) and .extend. It should be easy enough to work around using .extend but .ajax will take some work.

I think the default InfoWindows should be left as-is where the dev can set the exact content/style using a local template. however, AGS and A2E allows users to define InfoWindows in design mode and many users would expect these templates (well, the results of the template) to be used automatically. This makes their InfoWindow experience uniform over many different cleint apps (ArcMap, the AGS javascrip API, eventually ArcGIS.com, Google Earth etc)

so, a good option would be to use HTML generated at the server for the infowindow and use Ajax to fetch the html for the popup (or maybe an iframe for better css support?) The REST api supports feature based HTMLPopups:
http://atlas.resources.ca.gov/arcgis/SDK/REST/fs-htmlPopup.html

examples:
http://sampleserver3.arcgisonline.com/ArcGIS/rest/services/Hydrography/Watershed173811/FeatureServer/1/1/htmlPopup?f=html

http://sync.arc2earth.com/9280826/ArcGIS/rest/services/tfs/1920753/FeatureServer/0/1/htmlPopup?f=html

these Urls could easily be created by the framework, so all we would need is a simple option like "serverInfoWindows":true

We're injecting <script src="http://..."></script> for JSONP requests. We should probably remove these from the DOM once they're finished.

Is this possible?

jQuery.ajax is probably a good place to look for pointers.

We're currently assuming if a feature's properties changed that the icon needs changed. We should only check to see if the attribute that is used to assign symbology has changed.

This keeps form repeating the exact same code in each of the supported layers.

The current code is kind of a hack for extending a _layer class. I've begun work on this in the oo branch.

It's possible to declare the version of the CartoDB API to use, but not in the documentation.

One last check for tabs before launching.

There should be lots more code comments to explain what's happening and why things are structure the way they are.

infoWindowTemplate currently accepts a simple string with mustached attributes ({STATE_NAME}). We should also accept a function that returns a formatted string (or HTML). This function gets passed the properties (or attributes) object so lots of cool things can be done with the values. Think Google Charts.

Just a reminder to stop using the gvector-include script.

We should let the user pass a click parameter which is a function that would be fired when someone clicked features in this layer. We could pass Google's click event object as well as the actual features (GeoJSON or EsriJSON) to this function.

I think the default InfoWindows should be left as-is where the dev can set the exact content/style using a local template. however, AGS and A2E allows users to define InfoWindows in design mode and many users would expect these templates (well, the results of the template) to be used automatically. This makes their InfoWindow experience uniform over many different cleint apps (ArcMap, the AGS javascrip API, eventually ArcGIS.com, Google Earth etc)

so, a good option would be to use HTML generated at the server for the infowindow and use Ajax to fetch the html for the popup (or maybe an iframe for better css support?) The REST api supports feature based HTMLPopups:
http://atlas.resources.ca.gov/arcgis/SDK/REST/fs-htmlPopup.html

examples:
http://sampleserver3.arcgisonline.com/ArcGIS/rest/services/Hydrography/Watershed173811/FeatureServer/1/1/htmlPopup?f=html

http://sync.arc2earth.com/9280826/ArcGIS/rest/services/tfs/1920753/FeatureServer/0/1/htmlPopup?f=html

these Urls could easily be created by the framework, so all we would need is a simple option like "serverInfoWindows":true