jasonlewis / expressive-date Goto Github PK

it would be awesome to have some additional methods:

• startOfWeek() - get start date of the week
• endOfWeek() - get end date of the week
• copy() - clone current date (usage: $date->copy()->startOfWeek())

Week methods also will require week start day definition:

• setWeekStartDay(0) - set Sunday is first day of the week (by default)
• setWeekStartDay(1) - set Monday is first day of the week

Also would be great to hint magic methods like getDay(),setMonth() and etc

I'm trying to use ExpressiveDate via composer although I cannot figure it out. I've tried...

$date = new \ExpressiveDate\ExpressiveDate();
$date = new \ExpressiveDate();
$date = new ExpressiveDate();

Have you thought at all about adding support for business days?

So for example, if

$date = new ExpressiveDate;  // Let's say this is a Friday
$date->addDays(1);  // This would give you Saturday

$date->addBusinessDays(1);  // This would give you Monday

Support for holidays would be a little more complicated, because we would probably need to pass in the holidays into object configuration somehow, since it will vary by country / locale.

But maybe, $holidays were an array of date objects:

$holidays = array(
    $monday
);
ExpressiveDave::initializeHolidays($holidays);
$date->addBusinessDays(1); // This would be Tuesday, since Monday is holiday

The default format is:
protected $defaultDateFormat = 'jS F, Y \a\\t g:ia';

https://github.com/jasonlewis/expressive-date/blob/master/src/ExpressiveDate.php#L36

But the README.md says the time looks like:
$date->startOfWeek(); // 26th November, 2012 at 12:00 AM

Shouldn't it be?:
$date->startOfWeek(); // 26th November, 2012 at 12:00am

This tripped me up a bit when I was TDDin of my classes.

Hi,
Major problem with PHP is that we can get long date only in English. I want to be able to get long date also in other languages.
For example, in English:
1 Jan 1970 / 1 January 1970
And in Polish:
1 sty 1970 / 1 stycznia 1970
Of course, I don't expect you to include translations by default. I only want to be able to translate it by myself using your lib.

Currently the getRelativeDate method only ouputs in english, it would be nice to be able to set a custom $units array and the ago string to allow manual translation of the date.

It'd be great if you could also integrate something like https://pear.php.net/package/Date_HumanDiff to generate time/dates in a human readable format.

Pardon, $date->getRelativeDate(); does that :)

I would like to use your php extension. I would like to translate (getRelativeDate() / $units prefix, postfix etc.). Can you solve this problem? For example if the extension use language file.. then I be able to translate. Thanks for your support.

It would be cool to be able to use relative date to a specific length, then use a more normal date.

Currently I write it something like this (pseudocode):

$date = new ExpressiveDate('January 31, 1991');
$current = new ExpressiveDate();

if($current->lessOrEqualTo($date->clone()->addOneWeek())) {
return $date->getRelativeDate();
} else {
return $date->getShortDate();
}

Trying to use minusHours() with anything less than one but greater than 0 throws the following exception.

Exception: DateInterval::__construct(): Unknown or bad format (PT0.5H)

There should be a check inside of modifyHours() that looks for floats between 0 and 1 and redirects them to modifyMinutes instead, since its perfectly reasonable that somebody might be trying to pass a fraction of an hour.