jarmuszz / sbo-shell Goto Github PK

SBo-shell supports a few env variables for setting options, document them,

The _tree user function was written fast and needs a rewrite. There's a couple things wrong with it:

• The -f flag may only be supplied as a first argument.
• It uses _source_info (which also needs to be separated into two functions) without a subshell which sets the .info variables globally.
• It has very leaky, argument checking.
• No proper error handling is implemented, weird errors pop-up.
• The intern_tree "$REQUIRES" | sort -u | sed 's/\s*//' | awk '!x[$0]++' is not super bad but another function for flat dependency tree should be created.

Currently, some user functions call other user functions which is a really bad practice. Some functions should be split into front-end and back-end parts (like _tree and intern_tree) where front-end function handles arguments and error-checking and calls the back-end function/s.

Split like this will not only improve performance but will also fix bugs and and make debugging easier.

Functions to split:

• _goto
• _find
• _source_info
• _unset_info
• And probably others

New functions to implement:

• Check whether package is installed
  • Split into front-end and back-end functions
• Check whether package SBo repository tree is out-of-date
  • Easily doable for github.
  • Maybe automatic .info patching.

Possibly more to come.

When sbo-shell starts set some variable, when it ends unset it. At the end of the file check whether the said variable is set or not.

The _restart function will be a lot more tricky - because sbo-shell is suposed to be sourced, the $0 is equal to shell's $0, and ergo, sbo-shell doesn't know it's path.