Comments (8)
Nice find!
It actually looks like there might be several dependencies that are in devDependencies
when they need to be in dependecies
... and styled-components
is only one of them. I'll get this fixed!
from react-crossword.
This auto-closed by virtue of mention the fix in a commit... I'm re-opening until I can verify that the published update actually fixes the problem!
from react-crossword.
🎉 This issue has been resolved in version 2.2.2 🎉
The release is available on:
Your semantic-release bot 📦🚀
from react-crossword.
Excellent! Version 2.2.2 (or 2.2.3 which has Snyk vulnerability patching added) properly exports ThemeProvider! My test consumer (a simple create-react-app) pulls in only React and this crossword package, and it's able to use the exported ThemeProvider
as intended.
Thanks for the find, @zehawki!
from react-crossword.
Sweet. I'll give it a whirl in a bit and report back. Thankoo.
from react-crossword.
A bit puzzled here. Why would this package need so many dependencies?
[4/4] Building fresh packages...
success Saved lockfile.
success Saved 187 new dependencies.
info Direct dependencies
└─ @jaredreisinger/[email protected]
info All dependencies
├─ @arcanis/[email protected]
├─ @emotion/[email protected]
├─ @jaredreisinger/[email protected]
├─ @nodelib/[email protected]
├─ @nodelib/[email protected]
├─ @nodelib/[email protected]
├─ @octetstream/[email protected]
├─ @sindresorhus/[email protected]
├─ @snyk/[email protected]
├─ @snyk/[email protected]
├─ @snyk/[email protected]
├─ @snyk/[email protected]
├─ @snyk/[email protected]
├─ @snyk/[email protected]
├─ @snyk/[email protected]
├─ @snyk/[email protected]
├─ @snyk/[email protected]
├─ @snyk/[email protected]
├─ @snyk/[email protected]
├─ @snyk/[email protected]
├─ @szmarczak/[email protected]
├─ @types/[email protected]
├─ @types/[email protected]
├─ @types/[email protected]
├─ @types/[email protected]
├─ @types/[email protected]
├─ @types/[email protected]
├─ @types/[email protected]
├─ @types/[email protected]
├─ @types/[email protected]
├─ @types/[email protected]
├─ @types/[email protected]
├─ @types/[email protected]
├─ @yarnpkg/[email protected]
├─ @yarnpkg/[email protected]
├─ @yarnpkg/[email protected]
├─ @yarnpkg/[email protected]
├─ @yarnpkg/[email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
└─ [email protected]
from react-crossword.
Neither styled-components
nor immer
actually pull in any transitive dependencies... so that's entirely due to Snyk. It might be that their default process is to make snyk
a regular dependency rather than just a devDependency
... which seems sloppy, in my opinion. I'll take a look and see if I can scale that back some. (Feel free to create a new issue for it, if you like!)
from react-crossword.
I'm going to create a new issue for this, and reference you, so that we can have the discussion in a "clean" issue. 😄
from react-crossword.
Related Issues (20)
- Allow to set cell programmatically? HOT 4
- A callback function that notifies that the word is guessed incorrectly HOT 3
- How to replace (localize) direction header? HOT 3
- Allow clues to appear separate from answer grid HOT 2
- Imperative `isCrosswordCorrect()` function returns `false` after web page reloads HOT 8
- Rich text formatting of clues HOT 2
- Snyk brings in a boat-load of dependencies HOT 9
- Allow retrieval of player's guess onAnswerComplete
- Node version > 10.18 HOT 1
- Support .ipuz format HOT 2
- Cell input not functioning
- More natural navigation through the puzzle? HOT 2
- a11y issues preventing usage by people with disabilities HOT 2
- Allow to show what characters have been entered correctly/incorrectly HOT 8
- i've run every example in the repo and it doesn't work HOT 2
- Call onClueSelected on click of cell and input to know the clue
- Cell Overwritten at Junction HOT 2
- Allow unused cells
- Allow define how an answer is correct?
- Imperative methods & Player progress events HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react-crossword.