Code Monkey home page Code Monkey logo

Comments (8)

JaredReisinger avatar JaredReisinger commented on May 22, 2024

Nice find!

It actually looks like there might be several dependencies that are in devDependencies when they need to be in dependecies... and styled-components is only one of them. I'll get this fixed!

from react-crossword.

JaredReisinger avatar JaredReisinger commented on May 22, 2024

This auto-closed by virtue of mention the fix in a commit... I'm re-opening until I can verify that the published update actually fixes the problem!

from react-crossword.

JaredReisinger avatar JaredReisinger commented on May 22, 2024

🎉 This issue has been resolved in version 2.2.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

from react-crossword.

JaredReisinger avatar JaredReisinger commented on May 22, 2024

Excellent! Version 2.2.2 (or 2.2.3 which has Snyk vulnerability patching added) properly exports ThemeProvider! My test consumer (a simple create-react-app) pulls in only React and this crossword package, and it's able to use the exported ThemeProvider as intended.

Thanks for the find, @zehawki!

from react-crossword.

zehawki avatar zehawki commented on May 22, 2024

Sweet. I'll give it a whirl in a bit and report back. Thankoo.

from react-crossword.

zehawki avatar zehawki commented on May 22, 2024

A bit puzzled here. Why would this package need so many dependencies?

[4/4] Building fresh packages...
success Saved lockfile.
success Saved 187 new dependencies.
info Direct dependencies
└─ @jaredreisinger/[email protected]
info All dependencies
├─ @arcanis/[email protected]
├─ @emotion/[email protected]
├─ @jaredreisinger/[email protected]
├─ @nodelib/[email protected]
├─ @nodelib/[email protected]
├─ @nodelib/[email protected]
├─ @octetstream/[email protected]
├─ @sindresorhus/[email protected]
├─ @snyk/[email protected]
├─ @snyk/[email protected]
├─ @snyk/[email protected]
├─ @snyk/[email protected]
├─ @snyk/[email protected]
├─ @snyk/[email protected]
├─ @snyk/[email protected]
├─ @snyk/[email protected]
├─ @snyk/[email protected]
├─ @snyk/[email protected]
├─ @snyk/[email protected]
├─ @snyk/[email protected]
├─ @szmarczak/[email protected]
├─ @types/[email protected]
├─ @types/[email protected]
├─ @types/[email protected]
├─ @types/[email protected]
├─ @types/[email protected]
├─ @types/[email protected]
├─ @types/[email protected]
├─ @types/[email protected]
├─ @types/[email protected]
├─ @types/[email protected]
├─ @types/[email protected]
├─ @types/[email protected]
├─ @yarnpkg/[email protected]
├─ @yarnpkg/[email protected]
├─ @yarnpkg/[email protected]
├─ @yarnpkg/[email protected]
├─ @yarnpkg/[email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
├─ [email protected]
└─ [email protected]

from react-crossword.

JaredReisinger avatar JaredReisinger commented on May 22, 2024

Neither styled-components nor immer actually pull in any transitive dependencies... so that's entirely due to Snyk. It might be that their default process is to make snyk a regular dependency rather than just a devDependency... which seems sloppy, in my opinion. I'll take a look and see if I can scale that back some. (Feel free to create a new issue for it, if you like!)

from react-crossword.

JaredReisinger avatar JaredReisinger commented on May 22, 2024

I'm going to create a new issue for this, and reference you, so that we can have the discussion in a "clean" issue. 😄

from react-crossword.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.