jaredpar / editorutils Goto Github PK

I have a VS extension I'm playing around with. In it I have a class that implements ITag. But I want to change it to implement IBasicTaggerSource<T> from EditorUtils. But when I do, the build blows up even though I implemented all of the members.

public sealed class LinkTaggerSource : IBasicTaggerSource<ClassificationTag> {...}

You can see that it says get_TextSnapshot is missing, but I see the property right there just fine. You can see the method in the IL.

1> Code Analysis Complete -- 0 error(s), 0 warning(s)
1> Creating intermediate PkgDef file.
1>C:\Program Files (x86)\MSBuild\Microsoft\VisualStudio\v12.0\VSSDK\Microsoft.VsSDK.targets(761,5): error : CreatePkgDef : error : ReflectionTypeLoadException: Unable to load one or more of the requested types. Retrieve the LoaderExceptions property for more information.
1>C:\Program Files (x86)\MSBuild\Microsoft\VisualStudio\v12.0\VSSDK\Microsoft.VsSDK.targets(761,5): error : at System.Reflection.RuntimeModule.GetTypes(RuntimeModule module)
1>C:\Program Files (x86)\MSBuild\Microsoft\VisualStudio\v12.0\VSSDK\Microsoft.VsSDK.targets(761,5): error : at System.Reflection.RuntimeModule.GetTypes()
1>C:\Program Files (x86)\MSBuild\Microsoft\VisualStudio\v12.0\VSSDK\Microsoft.VsSDK.targets(761,5): error : at System.Reflection.Assembly.GetTypes()
1>C:\Program Files (x86)\MSBuild\Microsoft\VisualStudio\v12.0\VSSDK\Microsoft.VsSDK.targets(761,5): error : at Microsoft.VisualStudio.Tools.CreatePkgDef.ProcessAssembly(String fileName, Hive hive, PkgDefContext context, Boolean register, RegistrationMode mode) in f:\dd\VSSDK\VSIntegration\Tools\src\CreatePkgDef\CreatePkgDef.cs:line 260
1>C:\Program Files (x86)\MSBuild\Microsoft\VisualStudio\v12.0\VSSDK\Microsoft.VsSDK.targets(761,5): error : at Microsoft.VisualStudio.Tools.CreatePkgDef.DoCreatePkgDef(InputArguments inputArguments) in f:\dd\VSSDK\VSIntegration\Tools\src\CreatePkgDef\CreatePkgDef.cs:line 164
1>C:\Program Files (x86)\MSBuild\Microsoft\VisualStudio\v12.0\VSSDK\Microsoft.VsSDK.targets(761,5): error : at Microsoft.VisualStudio.Tools.CreatePkgDef.Main(String[] arguments) in f:\dd\VSSDK\VSIntegration\Tools\src\CreatePkgDef\CreatePkgDef.cs:line 85
1>C:\Program Files (x86)\MSBuild\Microsoft\VisualStudio\v12.0\VSSDK\Microsoft.VsSDK.targets(761,5): error : Method 'get_TextSnapshot' in type 'Haack.UI.Adornments.LinkTagger.LinkTaggerSource' from assembly 'Haack.Experiment, Version=0.1.0.0, Culture=neutral, PublicKeyToken=null' does not have an implementation.
1>C:\Program Files (x86)\MSBuild\Microsoft\VisualStudio\v12.0\VSSDK\Microsoft.VsSDK.targets(761,5): error :

Any thoughts?

I installed the EditorUtils package and noticed the following error.

Import-Module : The specified module 'C:\dev\VisualStudio\packages\EditorUtils.1.4.0.0\tools\EditorUtils.psm1' was not loaded because no valid module file was found in any module directory.
At C:\dev\VisualStudio\packages\EditorUtils.1.4.0.0\tools\Init.ps1:7 char:1

• Import-Module -force (Join-Path $toolsPath "EditorUtils.psm1")

• - CategoryInfo          : ResourceUnavailable: (C:\dev\VisualSt...ditorUtils.psm1:String) [Import-Module], FileNotFoundException
  - FullyQualifiedErrorId : Modules_ModuleNotFound,Microsoft.PowerShell.Commands.ImportModuleCommand
  

The design of EditorUtils NuGet packaging and testing strategy is 5+ years old. It was done at a time when I had less understanding of binding redirects, assembly resolution and the GAC. As a result I missed a couple of important scenarios but was constantly saved by the fact that all of the editor assemblies were in the GAC. Now that VS 2017 is out and have removed all of the GAC entries these flaws are showing now and causing me to rethink the setup.

The testing strategy was designed around the idea that a developer could:

• Add a reference to EditorUtils VS version X
• Use binding redirects to test against VS version X, X +1, etc ...

This meant at build time you could control the VS version to test against by simply changing the binding redirects. In general it would essentially work like the following:

• EditorUtils compiled against 10.0.0.0
• Test directory has editor assemblies version 10.0.0.0
• Binding redirect moves 10.0.0.0 -> 14.0.0.0
• At runtime
  • None of the editor assemblies in test directory match due to the redirect.
  • The assemblies do exist in the GAC and win

That runtime behavior really falls apart in VS 2017 because there is no GAC. It's making me question the overall strategy here.