jaredkrinke / goldsmith Goto Github PK

Hi again. I'm running your unmodified (by me) version and I'm getting errors when the .md file has a TOC. Here is part of the TOC -

<!-- TOC start -->
- [**Introduction - August 2022**](#introduction-august-2022)
- [**Upcoming SISKA Events**](#upcoming-siska-events)
- [**Upcoming NonSISKA Events**](#upcoming-nonsiska-events)
- [**Community Events of Interest**](#community-events-of-interest)
- [**Upcoming Courses**](#upcoming-courses)

Here is the error -

md2blog --clean --serve
←[0m←[1m←[31merror←[0m: TypeError: Cannot read properties of undefined (reading 'split')
    at file://$deno$/bundle.js:7162:66
    at GoldsmithObject.run (file://$deno$/bundle.js:1457:28)
    at async GoldsmithObject.build (file://$deno$/bundle.js:1493:23)
    at async file://$deno$/bundle.js:55045:1

Anything come to mind?

          > I asked why no id's, but they didn't seem to want to change until "name" stopped working everywhere.

Well, it seems to be deprecated as of HTML 5 (for a): https://developer.mozilla.org/en-US/docs/Web/HTML/Element/a#name

So I'd say we're both wrong: they should probably not use it (unless targeting HTML 4), but since it works in browsers, I probably should support it (i.e. not flag links as broken in this scenario).

Originally posted by @jaredkrinke in #3 (comment)

• Serialize entire pipeline
• Check for pipeline changes (or store objects per pipeline?)
• Add new "transform" plugin type for transforming/renaming items in isolation
• Add incremental rebuild option
• Serialize objects
• Serialize dependency graph
• Benchmark md2blog before and after
• Test old and new md2blog to ensure no changes
• Add tests for incremental updates
• Consider running transformers in parallel, via workers (if supported)

Convert these plugins to transformers:

• Front matter
• Drafts
• File metadata (note: md2blog uses index plugin data! Good test case)
• Inject files (md2blog uses site metadata here)
• Markdown
• Root paths
• md2blog's header defaults... I think
• Layout

Probably fairly easy to add...