janxious / bt-weaponrealizer Goto Github PK

I dont know which piece in the end doesnt want to work there, its quite a mess i cant find where it decides to not work

with BT versions 1.4 and 1.5 weapon realizer is causing severe slideshow issues in combat.
without WR i get 30 to 60 fps depending on whats happening.
with WR it will drop to single digits and stutter especially with missile fire

Misfire triggers after every shot and not just after the weapon had fired and active "refiremodifier" from previous shots

Fresh download: Not compatible with newest version?

ModTek v0.7.2 -- 6/18/2019 9:59:34 PM
Building new config.
Building new load order!

WeaponRealizer 0.5.0
Loaded assembly WeaponRealizer (v0.5.0.42185)
Invoking 'Core.Init(String directory, String settingsJson)' using parameter dictionary
Error: While invoking 'Core.Init', an exception occured
System.Reflection.TargetInvocationException: Exception has been thrown by the target of an invocation. ---> System.Exception: Exception from HarmonyInstance "com.joelmeador.WeaponRealizer" ---> System.Reflection.TargetInvocationException: Exception has been thrown by the target of an invocation. ---> System.ArgumentOutOfRangeException: Argument is out of range.
Parameter name: index
at System.Collections.Generic.List1[Harmony.CodeInstruction].CheckIndex (Int32 index) [0x00000] in <filename unknown>:0 at System.Collections.Generic.List1[Harmony.CodeInstruction].InsertRange (Int32 index, IEnumerable1 collection) [0x00000] in <filename unknown>:0 at WeaponRealizer.AttackSequencePatcher.Transpiler (IEnumerable1 instructions) [0x00000] in :0
at (wrapper managed-to-native) System.Reflection.MonoMethod:InternalInvoke (object,object[],System.Exception&)
at System.Reflection.MonoMethod.Invoke (System.Object obj, BindingFlags invokeAttr, System.Reflection.Binder binder, System.Object[] parameters, System.Globalization.CultureInfo culture) [0x00000] in :0
--- End of inner exception stack trace ---
at System.Reflection.MonoMethod.Invoke (System.Object obj, BindingFlags invokeAttr, System.Reflection.Binder binder, System.Object[] parameters, System.Globalization.CultureInfo culture) [0x00000] in :0
at System.Reflection.MethodBase.Invoke (System.Object obj, System.Object[] parameters) [0x00000] in :0
at Harmony.CodeTranspiler+<>c__DisplayClass10_0.b__0 (System.Reflection.MethodInfo transpiler) [0x00000] in :0
at System.Collections.Generic.List1[System.Reflection.MethodInfo].ForEach (System.Action1 action) [0x00000] in :0
at Harmony.CodeTranspiler.GetResult (System.Reflection.Emit.ILGenerator generator, System.Reflection.MethodBase method) [0x00000] in :0
at Harmony.ILCopying.MethodBodyReader.FinalizeILCodes (System.Collections.Generic.List1 transpilers, System.Collections.Generic.List1 endLabels, System.Collections.Generic.List1 endBlocks) [0x00000] in <filename unknown>:0 at Harmony.ILCopying.MethodCopier.Finalize (System.Collections.Generic.List1 endLabels, System.Collections.Generic.List1 endBlocks) [0x00000] in <filename unknown>:0 at Harmony.MethodPatcher.CreatePatchedMethod (System.Reflection.MethodBase original, System.String harmonyInstanceID, System.Collections.Generic.List1 prefixes, System.Collections.Generic.List1 postfixes, System.Collections.Generic.List1 transpilers) [0x00000] in :0
--- End of inner exception stack trace ---
at Harmony.MethodPatcher.CreatePatchedMethod (System.Reflection.MethodBase original, System.String harmonyInstanceID, System.Collections.Generic.List1 prefixes, System.Collections.Generic.List1 postfixes, System.Collections.Generic.List1 transpilers) [0x00000] in <filename unknown>:0 at Harmony.PatchFunctions.UpdateWrapper (System.Reflection.MethodBase original, Harmony.PatchInfo patchInfo, System.String instanceID) [0x00000] in <filename unknown>:0 at Harmony.PatchProcessor.Patch () [0x00000] in <filename unknown>:0 at Harmony.HarmonyInstance.<PatchAll>b__9_0 (System.Type type) [0x00000] in <filename unknown>:0 at Harmony.CollectionExtensions.Do[Type] (IEnumerable1 sequence, System.Action1 action) [0x00000] in <filename unknown>:0 at Harmony.HarmonyInstance.PatchAll (System.Reflection.Assembly assembly) [0x00000] in <filename unknown>:0 at WeaponRealizer.Core.Init (System.String directory, System.String settingsJson) [0x00000] in <filename unknown>:0 at (wrapper managed-to-native) System.Reflection.MonoMethod:InternalInvoke (object,object[],System.Exception&) at System.Reflection.MonoMethod.Invoke (System.Object obj, BindingFlags invokeAttr, System.Reflection.Binder binder, System.Object[] parameters, System.Globalization.CultureInfo culture) [0x00000] in <filename unknown>:0 --- End of inner exception stack trace --- at System.Reflection.MonoMethod.Invoke (System.Object obj, BindingFlags invokeAttr, System.Reflection.Binder binder, System.Object[] parameters, System.Globalization.CultureInfo culture) [0x00000] in <filename unknown>:0 at System.Reflection.MethodBase.Invoke (System.Object obj, System.Object[] parameters) [0x00000] in <filename unknown>:0 at ModTek.Util.AssemblyUtil.InvokeMethodByParameterNames (System.Reflection.MethodInfo method, System.Collections.Generic.Dictionary2 paramsDictionary) [0x00000] in :0
at ModTek.ModTek.LoadAssemblyAndCallInit (ModTek.ModDef modDef) [0x00000] in :0

Adding Mod Content...
Building new Type Cache.

Doing merges...
Building new Merge Cache.

Syncing Database...
Copying over DB and building new DB Cache.

Finishing Up

9:59:36 PM - Done. Elapsed running time: 1.48546 seconds

After downloading and unzipping the addon - loading brings the following message in the ModTek.log

WeaponRealizer 0.5.0
WeaponRealizer has a DLL specified (C:\Games\SteamLibrary\steamapps\common\BATTLETECH\Mods\BT-WeaponRealizer-master\WeaponRealizer.dll), but it's missing! Aborting load.

For example, a new artillery system which requires bracing before firing, a crude implementation could be weapon becomes disabled upon moving, disables moving after firing.

I've installed WR 0.5.0, and a version of the LB 10-X (I created) seems to not work properly. I've properly tagged it as "wr-clustered_shots", but when it fires, it seems like I'm only getting a single hit instead of multiple cluster hits (the animation still properly plays multiple shots). Has something changed? The other functions of WR seem to working fine.

I'm using with mainly vanilla mods, not Roguetech or anything special.

Per Lore Artemis IV/V equipped missiles get a bonus to hit/cluster hit when fired with direct LoS, no bonus is conferred when fired indirectly. There is no way, currently, to have missile launchers differentiate between direct LoS and indirect fire when applying accuracy bonus ("AccuracyModifier" in weapon json).

Is it possible to add a tag and code to account for this in Weapon Realizer?

Sarna Link to Artemis IV: http://www.sarna.net/wiki/Artemis_IV_FCS (+2 cluster hit roll)
Sarna Link to Artemis V: http://www.sarna.net/wiki/Artemis_V_FCS (-1 to hit roll and +3 to cluster hit roll)