jangerritharms / rs-async-api Goto Github PK

Current behavior

Logging with println!().

Proposed/expected behavior

Should be logging using a more flexible logger. E.g. log.

Current behavior

If the API request fails and encounters an error, the stream of trades silently returns an empty Vec<>.

Expected behavior

An error should be bubbled up to the caller, where it can be handled.

Possible solution

Return a impl Stream<Item = Result<Trade, Error>> instead of impl Stream<Item = Trade>. Once an error has been encountered, the PaginationHelper should tell the next iteration that an error occurred in the previous iteration and return None to stop the stream.