Different text color for PHP variables? [Enhancement] about predawn HOT 14 CLOSED

I agree. I'll see if I can fix that in the next couple of days. Thanks for the feedback.

from predawn.

Hey @samnabi I don't write PHP, so let me know if this is helpful or wierd.

from predawn.

The only change I'd make would be to keep the $ the same colour as the variable name. Other than that, looks great!

from predawn.

I updated that variable punctuation to match the name. Thanks for your help.

from predawn.

Beautiful. Thanks a lot!

from predawn.

@jamiewilson I think you may want to check out the color styles for text within single quotes in PHP. I'm seeing some inconsistencies (see attached screenshot, gray vs light blue color)

from predawn.

Uh oh. @pstinnett which would you prefer. the gray or the light blue?

from predawn.

@jamiewilson Light blue for sure. The gray is great for comments but probably shouldn't match.

Sidenote - is there a tmTheme overview anywhere you'd recommend? Would love to help contribute for some of this stuff (especially since you mentioned you don't use PHP regularly!)

from predawn.

I wish. There is very little documentation out there. I've learned strictly by trial and error. If you put the caret in a piece of code and press Opt + Cmd + P it show you the scope names in the status bar. But it can't be copied and pasted and only stays visible for a few seconds. Ah! annoying.

But please help in any way you can! Package control is updated through the Release tags, so you can submit pull requests directly to the master branch. Thanks!

from predawn.

Also, I removed that single quote color. It is now light blue. but I'll hold off on a new release if you have other changes you'd like to make.

from predawn.

@jamiewilson Thanks for the quick work! I'll start messing around too but in the meantime thought I'd post this:

I pulled that fix but I'm still seeing some issues / inconsistencies. It's definitely fixed in the example I posted up but just glancing through some other files I see some issues.

Specifically when the single quote is preceded by a forward-slash (see difference in lines 108 and 109 in attachment.)

from predawn.

Okay, I'll check that out. Could you send me several of your php files? Also, there is this tmTheme editor, but I don't find it very easy to use.

http://tmtheme-editor.herokuapp.com/

from predawn.

Sure thing - here's a link to the same file I was referencing.

https://raw.github.com/focuslabllc/ee-master-config/master/config/config.master.php

from predawn.

@pstinnett cool. also, I just added a color key in the xml file. Should a make it a little easier to apply changes.

from predawn.