jameelmoses / acf-icomoon Goto Github PK

Hello, thanks for doing to hard part and putting this little plugin together!

However I found a little bug that I had to tweak for it to work for me. Line number 66 of icomoon-base-field.php has a regex string that does not work with CSS generated straight from Iomoon App. My CSS comes with only 1 : for all of my :befores. So I had to make a slight adjustment.

Old Line 66:
preg_match_all( '#.icon-(.*)::before#', $contents, $css );

Now Line 66:
preg_match_all( '#.icon-(.*):before#', $contents, $css );

I wonder if making that string filterable would be even better, that way someone could use their own class name as well. Just a thought!

Thanks again!

The field will not save any value when used with ACF Pro 5.11.3 and WP 5.8.2.

When using ACF Pro 5.11.1 and WP 5.8.1 I was able to save values in fields that were not used in the block editor. Fields in block editor blocks would still not be saved.