jalios / eclipse-jcms-plugin-tools Goto Github PK

As existing "Convert to Maven Project", this would be usefull a same function to create the .project, with generated ".jcmsPluginNature" setup.

When not in project explorer or package view, I think ctx menu actions should not be proposed.
Examples: task list, SVN views, ...

Declare webapp project dependency in sync.conf file instead of .project.

It could be usefull to allow some regexp.
Eg: plugins/AcmePlugin/*/.-generated.css

Version 2.0.3 Beta
Eclipse neon 2

I have an recurring exception with Neon 2 with my plugins.

!ENTRY org.eclipse.core.jobs 4 2 2017-02-23 11:53:00.191
!MESSAGE An internal error occurred during: "Check preview sync".
!STACK 0
java.lang.NullPointerException
at com.jalios.ejpt.sync.strategy.FilesCouldBeMissed.getFilesInWebappPublicPluginDirectory(FilesCouldBeMissed.java:60)
at com.jalios.ejpt.sync.strategy.FilesCouldBeMissed.run(FilesCouldBeMissed.java:44)
at com.jalios.ejpt.sync.strategy.GlobalSyncStrategy.run(GlobalSyncStrategy.java:40)
at com.jalios.ejpt.jobs.Util.previewSync(Util.java:37)
at com.jalios.ejpt.jobs.SyncJob.run(SyncJob.java:31)
at org.eclipse.core.internal.jobs.Worker.run(Worker.java:55)

Plugin tree :

This exception appears since I use Neon 2, and randomly (I think).

Version 2.0.3 Beta
Eclipse neon

If i have one plugin named Plugin1, who override Plugin2 private file we have an exception :

!MESSAGE An internal error occurred during: "Check preview sync".
!STACK 0
java.lang.NullPointerException
    at com.jalios.ejpt.sync.strategy.FilesCouldBeMissed.getFilesInWebappPublicPluginDirectory(FilesCouldBeMissed.java:60)
    at com.jalios.ejpt.sync.strategy.FilesCouldBeMissed.run(FilesCouldBeMissed.java:44)
    at com.jalios.ejpt.sync.strategy.GlobalSyncStrategy.run(GlobalSyncStrategy.java:40)
    at com.jalios.ejpt.jobs.Util.previewSync(Util.java:37)
    at com.jalios.ejpt.jobs.SyncJob.run(SyncJob.java:31)
    at org.eclipse.core.internal.jobs.Worker.run(Worker.java:55)

Directory tree :

WEB-INF/plugins/Plugin1/plugin.xml
WEB-INF/plugins/Plugin1/properties/language/fr.prop
WEB-INF/plugins/Plugin1/properties/language/en.prop
WEB-INF/plugins/Plugin1/properties/plugin.prop
WEB-INF/plugins/Plugin2/properties/fr.prop

WEB-INF/plugins/Plugin1/plugin.xml contains the webapp declaration of "WEB-INF/plugins/Plugin2/properties/fr.prop"

If i remove "WEB-INF/plugins/Plugin2/properties/fr.prop" it's work

Since sync is based on plugin.xml parsing, unittests are no longer synced.
Allow to sync unittests (or any other directory, or files) between plugin and webapp, event if it is not declared in plugin.xml.
Such a directory could be voluntary not declared for it NOT to be packaged in a plugin.zip.

Workaround :

• declare package unittests in plugin.xml lusing:
• preview and perform Sync (unittests are synced)
• remove package declaration

Ignored files can be declared given their filename only (not the path, neither relative, or absolute).
If multiple files have same name in the plugin, they will all be ommited. (ex: thumbnail.jpg for differents resources).

Improvement: make the declaration "unique"

Exemple of current declaration:

excluded.files = thumbnail.jpg

Proposed declaration:

excluded.files = **/images/**/thumbnail.jpg

Relates to: #4

This would be usefull for community to provide a Github .README file with following :

• installation
• how to use
  (existing documentation is provided on https://community.jalios.com)

For all plugin users to have common ignored file setup, this setup should be in a plugin file, not in the webapp sync.conf file.

For local change, use label "LocalChange"
For SVN Server change, use label "RemoteChange"