jake-jensen / sapphirelibv5 Goto Github PK

• Line 521 : Warning: hMem could be 0 and does not adhere to specification of GlobalLock

• Line 521: Warning: Temp_Value could be 0 and does not adhere to specification of memcpy

• Line 631: Warning: strcpy is unsafe. Use strcpy_s

• Line 643: Warning: fopen is unsafe. Use fopen_s

• Line 694: Conversion from int to size_t (Not really an issue here, but will fix anyways)

• Ton of warnings about using convert in s2ws and ws2s. MultibyteToWideChar and WideCharToMultibyte should be used instead

Add required license for cURL (https://curl.se/docs/copyright.html) and zLib (https://opensource.org/licenses/Zlib#:~:text=This%20software%20is%20provided%20'as,any%20express%20or%20implied%20warranty.&text=Permission%20is%20granted%20to%20anyone,1.)

If anyone wants a particular function added, or wants something created that fulfills a specific purpose, let me know and I'll see what I can do.

While this library is Windows specific, I'm not against adding POSIX specific functions to it via guards.

Since this library should be as compatible as possible, create a guard that disables the cURL, Windows, and other libraries if the requires files aren't present (such as the user not having cURL to begin with)