jadarnel27 / sqlserverversionscript Goto Github PK

The table definition states "MainstreamSupportEndDate date not null,", but in the data there are records with NULL values.

for example:
"(13, 5149, 'SP2 CU1', 'https://support.microsoft.com/en-us/help/4135048', '2018-05-30', NULL, NULL, 'SQL Server 2016', 'Service Pack 2 Cumulative Update 1'),"

This is not allowed:
Cannot insert the value NULL into column 'MainstreamSupportEndDate', table 'DBADB.dbo.SqlServerVersions'; column does not allow nulls. INSERT fails.

Same goes for ExtendedSupportEndDate

After fixing #9 and running the produced SQL I get the following error:

Msg 515, Level 16, State 2, Line 1
Cannot insert the value NULL into column 'MainstreamSupportEndDate', table 'DBADB.dbo.SqlServerVersions'; column does not allow nulls. INSERT fails.

It seems this is the one giving the problem:
(12, 6024, 'SP3 ', 'https://support.microsoft.com/en-us/help/4022619', '2018-10-30', NULL, NULL, 'SQL Server 2014', 'Service Pack 3 '),

Thanks for adding the primary key.
I do have an issue with using the produced script.

Due to the replication I am not able/allowed to drop the table.
"Cannot drop the table 'dbo.SqlServerVersions' because it is being used for replication."

Would be nice if there was a commandline option which let's you decide to create a full script (including creation of the table), or 'just' the data, with an additional DELETE statement to clean the table first.

DELETE
FROM dbo.SqlServerVersions

Per a request in the First Responder Kit repo, we should

• use OBJECT_ID to check for table existence
• include the schema in the existence check
• add GO where appropriate for proper batching

Pretty please thanks

SQL Server 2014 SP3 has been added to the support site now, so the custom code for that can now be removed.

The SqlServerVersions table does not contain a primary key, this won't allow us to replicate this table through our central DBADA database.

One way would be to create a clustered key on 'MajorVersionNumber', 'MinorVersionNumber' and 'ReleaseDate', this can be done by adding this to the table creation.

CONSTRAINT [PK_SqlServerVersions] PRIMARY KEY CLUSTERED
(
[MajorVersionNumber] ASC,
[MinorVersionNumber] ASC,
[ReleaseDate] ASC
)