Invalid variable reference syntax for variable git:branch about serverless-plugin-git-variables HOT 2 CLOSED

@hotgazpacho I thought I'd commented earlier this week, but evidently I did not. I took a look at this, and it appears that the issue is an interaction with how the mocha plugin loads the environment for the tests and how this plugin populates the variables. Specifically, this plugin hijacks the getValueFromSource call on serverless.variables (see https://github.com/jacob-meacham/serverless-plugin-git-variables/blob/develop/src/index.js#L24). However, the mocha plugin creates a new set of variables and tries to populate with that - without the hijacked function (see https://github.com/nordcloud/serverless-mocha-plugin/blob/master/index.js#L202). One fix in this plugin would be to hijack the Variable constructor and appropriately set getValueFromSource. One could also fix this in the mocha plugin by changing how the new set of variables are constructed. Happy to take a PR with the above fix - thanks!

from serverless-plugin-git-variables.

This may be fixed with sls v2/v3 which uses a less hacky way to specify variables

from serverless-plugin-git-variables.