Release 3.3.0 fails with invalid git command about serverless-plugin-git-variables HOT 5 CLOSED

Hi @ManfredLange sorry for the delay! I just released 3.3.1 which should fix this issue (if you're curious, you can find the PR here: #26

from serverless-plugin-git-variables.

@ManfredLange thanks for the report and sorry for the trouble! I missed the dependency on basename when I was reviewing the PR. A question though - I wouldn't expect this to break anything unless you were trying to use the new repository field. Is that the case?

from serverless-plugin-git-variables.

The variables we use in serverless.yml are as follows:

• git:branch
• git:describe
• git:sha1

We don't use any other variables.

The complete line that uses these is for a stackTag that we use in the deployment (with <org> and <repo-name> replaced with correct values):

git-info: "${git:branch} - ${git:describe} - ${git:sha1} - repo: https://github.com/<org>/<repo-name>"

My hunch regarding this issue: It could be caused by missing double quotes for a issuing a command. Nodejs on Windows can be a bit funny with that, e.g. when a command involves whitespaces. We often have to put double quotes around commands that in particular contain file names or paths.

from serverless-plugin-git-variables.

@jacob-meacham Hi, just a quick question: Do you happen to have an ETA for a release that fixes this issue?

I have never created a serverless plug-in or worked on the source of one. Do you happen to have a link to good instructions for how to set up a development environment for that? If I find time, I might try creating a PR to resolve this issue. Perhaps you could point me to the place in the codebase (filename, line number) that might cause this problem? Thank you!

from serverless-plugin-git-variables.

Just confirmed: This issue has been resolved with version 3.3.1. Thank you! @jacob-meacham !

Keep up the great work! This is really a very useful plugin for serverless framework.

from serverless-plugin-git-variables.