jacksenechal / skype-for-chrome Goto Github PK

8.0 2.0 9.0 413 KB

Creates Skype callto: links out of phone numbers in the page, so you can click to dial them.

License: BSD 3-Clause "New" or "Revised" License

JavaScript 75.25% HTML 24.75%

skype-for-chrome's Introduction

Fund this project!

This plugin will link phone numbers in web pages you visit, so that when you click them a call will be place with Skype, or any other application you configure to respond to a callto: URL.

Installation

Clone the git repository
Open the Chrome extensions window (Menu -> Tools -> Extensions)
Click the + next to "Developer Mode" if it's not already expanded
Click "Load unpacked extension...", and choose the extension's directory on your drive

Using The Plugin

This plugin simply turns phone numbers into links like "callto:+18005551212". Chrome will then hand that off to the OS to figure out what to do with it. Skype on Windows should register a handler for this type of URL. I'm not sure about Mac.

Linux

In Linux, Chrome uses the xdg-open command to open links like this. Skype doesn't automatically register a URL handler though, so that must be done manually.

Download the latest version of action_handler.py by Philipp Kilmann, from http://www.kolmann.at/philipp/linux/skype_action_handler/
Place that somewhere on your PATH (/usr/local/bin, for example).
Open a terminal and issue the following commands:

gconftool-2 -s -t string /desktop/gnome/url-handlers/callto/command '/usr/local/bin/action_handler.py "%s"' gconftool-2 -s -t bool /desktop/gnome/url-handlers/callto/enabled true
You may need to edit the action_handler.py script to account for the fact that Chrome URL encodes the phone number. So +18005551212 becomes %2B18005551212. Change the correct lines to look like the following:

import dbus import sys import re import string import urllib

...

user = "" cmd = "" multiuser = 0 arg1 = urllib.unquote(sys.argv[1]);

re1 = re.match('^(skype|callto|tel):/?/?([+]?[.\w-]+[;[.\w-]+]?)/?$', arg1); re2 = re.match('^(skype|callto|tel):/?/?([+]?[.\w-]+[;[.\w-]+]?)?(\w+)/?$', arg1); re3 = re.match('^(skype):/?/??(chat)&(blob)=([.\w-]+)/?$', arg1);

You may also be interested in the other scripts that Philipp Kolmann has put together for Skype on Linux. Check them out at http://www.kolmann.at/philipp/linux/.

To Do

Recognize more phone numbers
- look at http://stackoverflow.com/questions/123559/a-comprehensive-regex-for-phone-number-validation

Modification

Please do feel free to modify this plugin at will. The basic functionality is in the file contentscript.js. It is very simple at the moment. If you make additions that you would like to see included, just send me a Github pull request.

skype-for-chrome's People

Contributors

Stargazers

Watchers

Forkers

romans74 qeensh simobenso dcarter alexeyisakov quarantainenet avinashagarwal14 singhmohancs tryweirder

skype-for-chrome's Issues

Phone number regex

I am using this regex for a modified version of the Google Talk plugin:

/(^|\s)(+(9[976]\d|8[987530]\d|6[987]\d|5[90]\d|42\d|3[875]\d|2[98654321]\d|9[8543210]|8[6421]|6[6543210]|5[87654321]|4[987654310]|3[9643210]|2[70]|7)[0-9-. ]{1,14}|(?:+?1[-. ]?)?(?([0-9]{3}))?[-. ]?([0-9]{3})[-. ]?([0-9]{4}))(\s|$)/m

I matches valid international numbers up to 14 digits long separated by spaces, dashes (-) or periods (.) and in the case of US numbers it matches only 10 digit numbers in pretty much any valid format, with or without the country code.

Hope this is useful.

Would be great to add more specific validation for other countries as needed...

Causes Chrome to render .txt extensions

Enabling the Skype Links 0.3 extension causes chrome to render code (including javascript - window.location) in files with .txt extension. I would have thought chrome wouldn't pass a .txt file to be rendered.

Disabling the extension returns viewing these files as plain text.

It would be nice to have both functionality.

David

Opens Skype, but doesn't open user(s) or dial the number

I clicked a link for a US number, and it opened Skype (running in background already), and brought up the skype window, but didn't queue up the number to be dialed, nor did it dial the number, as I expected. I expected it start Skype (if not started), bring Skype window to foreground, and dial the number.

Is there something I've done wrong? I've installed the app, and tried changing to "tel" and "callto", but no difference.

What am I missing?

Win7-32
Skype 6.30.107

Thanks,

Mark
markfj(at)gmail(dot)com
Skype: markfj
334-714-4723

Telephone number 8 800 555-85-19

I meet here
this phone number
8 800 555-85-19
this must be tranformed in skypeto: +7 800 555-85-19

XSS Execution

Hi,

I've found a strange bug where by code quoted in the body of a page is being executed. This actually resulted in XSS type java popup. By a process of elimination I found this happens only when this extension is enabled.

The page this happened on is here

http://www.slideshare.net/zeroscience/cloudflare-vs-incapsula-vs-modsecurity

configure callto in Windows registry

I have been using Skype Links for Chrome. Thanks for the tool.

If it is possible I would like to configure the callto key in the windows registry to call a website with a get. For example: http://www.mywebsite.com?callto="555123456". Do you know how I would do that?

Currently my callto key is configured to Skype as below but I would like to change that to a website.

TIA

Current configuration:
[HKEY_CLASSES_ROOT\callto]
@="URL:Callto Protocol"
"URL Protocol"=""

[HKEY_CLASSES_ROOT\callto\DefaultIcon]
@=""C:\Program Files\Skype\Phone\Skype.exe",0"

[HKEY_CLASSES_ROOT\callto\shell]

Stopped working

I had this plugin working great after I reworked the Regex a bit. The other day, I notice my regex had been reset to default, and it doesn't pick up any numbers. It is actually behaving like it is not even enabled.

I made a test page with

Phone: 111-555-1212

I changed the regext to /\d/ and it still doesn't pick anything up?

The extension is enabled.

Conform to new creative assets guidelines

http://code.google.com/chrome/webstore/docs/images.html
https://mail.google.com/mail/#inbox/132db25b08f137b4

Opens new Chrome window instead of Skype

Not sure if I've messed something up, but I just installed the extension in Win 7 (from Google's Chrome Extensions site) and when I first clicked on a callto link, I got a lengthy message basically asking if I wanted it to launch Skype. I said yes, also checking the "make this the default behavior" box. But instead of a skype call starting, it just opens up a blank Chrome window. Not sure what to do. Skype has been installed all along and working fine. I'm also not sure how to un-set this as the default function for callto links now (which is really a "how do I use Chrome" question).

how do i use the skype link?

I have friends in Mexico who i like skyping with, ive never had a chromebook..and do not know how to use the skype on here. if it even has one!!!!

PLEASE tell how to get it and how to use it on the chromebook.

Skype Links extension for Chrome

Skype Links extension for Chrome does not work on many websites like yell.com
Why?

Thanks
Tony

Does this Chrome extension work on Mac OSX?

I run Mac OSX 10.7.2, Chrome 16.0.912.77 and Skype 5.3.59.1093.

I was trying to call the number on this page:

http://www.schoolstuff.com.au/index.php?option=com_content&task=view&id=1&Itemid=32

But couldn't see the Skype icon in the location bar or right click the number to call...

THanks

Ben

PS - sorry for raising an issue - couldn't get your email from GitHub...

Microsoft Lync Compatibility

This is an awesome extension for Chrome, but unfortunately I don't use Skype. This application almost works with Microsoft Lync though which is the app that I do use for voice calls (along with many other businesses). It would be great if there would be a way of producing a second version of this extension or adding the option in this extension to create the links in a way that MS Lync can interpret. This could be done very simply in two different ways.

MS Lync prefers links to be in the form of "tel:+11231231234"
but it can also read them in the form of "callto:tel:+11231231234"

You can read more about Lync links here: http://technet.microsoft.com/en-us/library/gg398376.aspx

I almost though that the "callto:tel:" method would work since you already support "callto:" links, but unfortunately the links weren't normalized from the regex. I think that it is discarding the "tel:" part when I add it in. I guess the simplest way to make this all work would be to allow for someone to add "tel:" in the first part of the normalization.

Please feel free to message me if there is anything I can do to help as far as testing goes.

Thank you!
-Aaron

Causes some page text with angle brackets to be hidden

I just found that when this extension is enabled, I was unable to view some text on certain webpages. I narrowed it down to a quick repro:

enable extension
visit http://docs.splunk.com/Documentation/Splunk/latest/admin/Propsconf
search for "for a given".

The sentence near the search result should display (I've replaced angle brackets with square brackets): "This stanza enables properties for a given [spec].". What is happening is that the portion including [spec] is hidden, but only when this extension is enabled.

To validate that this is a display issue, and not server-side:

View source of same webpage
search for "for a given"
Note that the HTML source includes: "This stanza enables properties for a given <spec>."