jacaetevha / finna-be-octo-hipster Goto Github PK

Exported the content of tab_colors.fish to .config/fish/conf.d/tab_colors.fish.

I encountered undefined method title error.

Fixed by renaming all title calls to fish_title

When launching a new shell no error occurs but when launching any of the commands the iTerm title becomes "0;" and the color doesn't get change

When content exported to .config/fish/functions/tab_colors.fish then every single function is undefined.

Is this a known issue? Are you experiencing it as well?

LMK, thank you

basename will report an error if the $0 happens to start with - (dash). Here is my fix. I would like to contribute via git push, but don't have the permission.

iTerm2-finna-be-octo-hipster$ git diff HEAD~1
diff --git a/iterm2_helpers.sh b/iterm2_helpers.sh
index a490205..6678224 100644
--- a/iterm2_helpers.sh
+++ b/iterm2_helpers.sh
@@ -21,14 +21,14 @@ title_help0()
{
echo "ERROR: No argument provided."
echo "Usage:"
-echo " basename $0 "title" to provide a new Terminal title."
+echo " basename -- $0 "title" to provide a new Terminal title."
}

title_help2()
{
echo "ERROR: Too many arguments provided."
echo "Usage:"
-echo " basename $0 "title" to provide a new Terminal title."
+echo " basename -- $0 "title" to provide a new Terminal title."
}

function set_iterm_title() {