jaapz / cryptsypythonapi Goto Github PK

Now you can only do 1 request per second, as for every request the nonce has to be higher than the last submitted nonce, and the current API uses the last unixtimestamp

Current docstring format is dumb

When you ask for your wallet, you get all the names of your currencies and the amount you have in this currencies. 'DOGE' '100000', but to trade in them you must also know the marketID, would be handy if you retrieve them.

And push the documentation to github pages or maybe pythonhosted...

https://coveralls.io/

What happens if a request fails or timeouts? What happens if an error code is returned?
Nothing... this should be fixed.

When getsinglemarketdata errors, it returns a succesfull=1 while something went wrong, giving the user a wrong impression about the succesfullness of the request.

Possible fixes:

• if API returns a False, but succesful is set to 1, set it back to 0 and return that to the user (hackish, but works)
• throw an exception when the API returns a False (nicer, IMHO)