j-easy / easy-states Goto Github PK

As of v1.0.1, the EventHandler interface is not generic. This requires a cast when using custom events:

public class MyEvent extends Event {
    
}

public class MyEventHandler implements EventHandler {
	
	@Override
	public void handleEvent(Event event) throws Exception {
		if (event instanceof MyEvent) {
			MyEvent myEvent = (MyEvent) event;
			// do something with myEvent
		}
	}
}

The EventHandler interface should be something like:

public interface EventHandler<E extends Event> {
    void handleEvent(E event) throws Exception;
}

to eliminate the need to do the cast.

as title

Hi, by looking at the code and the example, it seems to me like transitions are instant (so the name feels slightly misleading). But maybe I didn't grasp the details...

I'm thinking of two cases: animated transitions of variable duration and synchronous calls (for instance download a file from the web, and when the file is downloaded, the transition is complete).

Could you suggest how to implement such cases?

Thank you! Also for sharing your code :)

The default log format for JUL is not the best one (it spans two lines, the default date format is not compact, it does not show milliseconds, etc)

The JUL default log format should be changed to: %1$tF %tT.%1$tL %4$s [%2$s] - %5$s %6$s%n which is known to be better.

FiniteStateMachineImpl.currentState is set by constructor, and do not have a currentState set method. Then I set currentState by db, then how should I use for transition? Thanks

As of v1.0.1, org.jeasy.states.api.Event is an abstract class. It is better to change it into an interface and rename the current abstract class to AbstractEvent.