ixartz / astro-boilerplate-components Goto Github PK

Is this repository compatible with the new 3.0.x version of Astro?

Description:

In the current implementation of the NavMenuItem component, there is no way to specify the target attribute for the <a> tag. This is essential for controlling where the new link will be opened (e.g., in a new tab, same tab, etc.).

Current Behavior:

type INavMenuItemProps = {
  href: string;
  children: string;
};

const NavMenuItem = (props: INavMenuItemProps) => (
  <li className="hover:text-white">
    <a href={props.href}>{props.children}</a>
  </li>
);

Desired Behavior:

Add a target prop to the NavMenuItem component to allow users to specify the target attribute for the tag.

type INavMenuItemProps = {
  href: string;
  children: string;
  target?: '_blank' | '_self' | '_parent' | '_top' | string;
};

const NavMenuItem = (props: INavMenuItemProps) => (
  <li className="hover:text-white">
    <a href={props.href} target={props.target}>{props.children}</a>
  </li>
);

Steps to Reproduce:

1. Import and use the NavMenuItem component.
2. Try to specify the target prop.
3. Observe that the target prop is not available.

Expected Result:

Users should be able to specify the target prop to control where the link will open.

Actual Result:

The target prop is not available in the current implementation.

Additional Information:

This enhancement will provide more flexibility to users when using the NavMenuItem component, especially when they want links to open in new tabs or other specific frames.

Note: I'm happy to implement a fix for this issue.

Hi,

Nice boilerplate to start with.
I am playing with it a little bit for my website and was wondering where the social media icons are coming from.

I would like to add the Github icon and ideally it would match the great style you guys already built.

Thanks!

i am not able to add new page in the page folder.

The Getting Started instructions probably assume stuff that isn't clear.

For instance, do you need to have an existing Astro application in a sub-directory when you run the git clone command?

It isn't clear how the installation process will integrate at all with, well, anything.

I was using the Atro Boilerplate (https://github.com/ixartz/Astro-boilerplate) and have noticed that the components do not take any style props. This was also mentioned in an issue (ixartz/Astro-boilerplate#7). As a reply it was mentioned that the pull requests are welcome for this repo. So, I was curious if I could help with that. I am new to astro and typescript and I really wanna contribute to open-sourse. So, is there anything that I can help you guys? I am acutally looking for a first issue, because I haven't done any open-source contributions before. I would be really happy for this oportunity to help and also grow my own skills.

Thank you.

where is the stripe integration?