ivantrendafilov / confucius Goto Github PK

Hello,

I think, there's a big problem with InjectableConfiguration class. The logic of this class is very simply

setProperty(FILE_PARAM, filePath);
setProperty(CONTEXT_PARAM, context);

but it doesn't work cause of the fact const

private final static String FILE_PATH;

is already set up when AbstractConfiguration is loaded

static {
        FILE_PATH = System.getProperty(FILE_PARAM);
...

and this cannot be changed. So this class is useless for now 👎

If its a standard ini format, then the current codebase doesnt provide a way to get all sections in that configuration file (Something similar to HierarchicalINIConfiguration#getSections) . Is there a reason why this was not included.

It would be quite helpful to have something like that if we wanted to go through a list of sections and get values from each of them. I have a usecase where my section names are user-written, but each of those sections have a key that is standardized. Without getting the sections (or setting the conf.context), I wont be able to get those values right now.

I have a patch to get this in Parser.java but wasnt sure what was the best way to expose it as an API.

Thanks!

Section of front page:

"First, you need the Confucius jar file on your classpath. Confucius is available from Maven Central, so add to your pom.xml (or manually download ..." <--- this link on front page

For now, Confucius cannot load configuration from jar's (just because Parser reads file, and doesn't accept e.g. InputStream)

BufferedReader br = new BufferedReader(new FileReader(filename));

It should be gr8, if I can ask Confucius for configuration from my resources

Configurable config = InjectableConfiguration(this.getClass.getResourceAsStream("my-config.cfg", "Default")