itosho / easy-query Goto Github PK

This line https://github.com/itosho/easy-query/blob/master/src/Model/Behavior/InsertBehavior.php#L82 allows certain clever SQL strings that will not get escaped correctly. It would be better to use the query valueBinder to let PDO automatically do the real escaping for you

In this lines: https://github.com/itosho/easy-query/blob/master/src/Model/Behavior/InsertBehavior.php#L158-L161

you can do:

$existsConditions[$field . ' IS'] = $value; 

It will automatically do the right thing for you

Topic

• When cakephp is updated for 3.6.x, we don't use TableRegistory::get('yourTableName'), but $this->getTableLocator()->get('yourTableName')
• So, Please update the point of that 👆 in README.md

Can you support INSERT ~ SELECT val1, val2 FROM tmp WHERE NOT EXISTS(*) statement?

You have already support ON DUPLICATE KEY syntax, but it only helps me UNIQUE/PRIMARY keys' duplication.
I think the feature like bellow make this plugin more useful! 😄

api design

// Behavior's api
public function insertOnce(array $values, array $search = null)

usage 1

Specify search conditions.

$data = ['field1' => $val1, 'field2' => $val2];
$search = ['key' = $key];
$this->Table->insertOnce($data, $search);

generates sql statement bellow

INSERT INTO `table` (`field1`, `field2`)
SELECT "{$val1}", "{$val2}" FROM tmp WHERE NOT EXISTS(    
    SELECT * FROM table WHERE `key` = '{$key}'
)

usage 2

Auto set search conditions with inserting data.

$data = ['field1' => $val1, 'field2' => $val2];
$search = ['key' = $key];
$this->Table->insertOnce($data,);

generates sql statement bellow

INSERT INTO `table` (`field1`, `field2`)
SELECT "{$val1}", "{$val2}" FROM tmp WHERE NOT EXISTS(    
    SELECT * FROM table WHERE `field1` = '{$val1}' AND `field2` = '{$val2}'
)