A function that repeats only on each page? about svelte-spa-router HOT 4 CLOSED

This (listening on the $location store) is definitely a way. Another way (which might be better if you want to listen to changes on $querystring too) is to use the “routeLoaded” event and place the timeout on the callback.

As for opening a PR, why do you think this would be best in the router rather than in the users’ code? What problem are you trying to solve that would be best implemented in the router? As you know, I’m trying to keep the router lean and implement in there only things that can’t be done in any other way.

from svelte-spa-router.

Is it okay if I send a PR to embed these functions into the library?

from svelte-spa-router.

I think it's better to provide some of the functions involved in the task that work uniquely on each page. Isn't convenience the most important thing? (like a svelte?) If you don't like the idea of embedding this feature in the module, I think it's okay to just put it in my svelte-spa-chunk.

from svelte-spa-router.

svelte-spa-router is meant to be included in many different apps and, since it's front-end code, every bit of it gets shipped to clients. It's very important that we keep this lean and minimal, for speed, maintainability, reliability and security.

My "litmus test" for deciding on what goes in the router is that things get included if all these are true:

1. If it's not possible (or much more inconvenient) to achieve the same result if the code isn't part of the router itself
2. If it's a feature that would benefit a significant number of user.
3. The APIs are generic enough and not overly complicated

I'm afraid a PR like this would violate the condition 1, as it could be implemented in the app's code with just few lines of code:

<Router on:routeLoaded={routeLoaded} />
<script>
import { onDestroy } from 'svelte'
let interval = null
function routeLoaded(event) {
    if (interval) clearInterval(interval)
    interval = setInterval(something, 1000)
}
onDestroy(() => clearInterval(interval))
</script>

I'm also not sure about condition 2, as it seems something very specific to one use case

from svelte-spa-router.