Code Monkey home page Code Monkey logo

Comments (5)

ItalyPaleAle avatar ItalyPaleAle commented on August 15, 2024 2

@TorstenDittmann thanks for the PR.

I've been thinking about this, and I'm wondering if the best way would actually be to change the handler so it actually modifies the href element rather than waiting for a click? Otherwise, we'd have to support a lot of cases, such as middle button click, right-click and then "open in new tab", etc...

Thoughts?

from svelte-spa-router.

TorstenDittmann avatar TorstenDittmann commented on August 15, 2024

Could this be solved by looking for the missing hash and additionally maybe the length of window.history?

Edit: That approach didn't make any sense...

One solution that comes to my mind would be catching the event when somebody clicks with the middle button. The easiest solution would be, redirecting in the current tab when using middle click. But overwriting the behaviour of middle clicks would bug me as a user.

I would love to work on that.

from svelte-spa-router.

TorstenDittmann avatar TorstenDittmann commented on August 15, 2024

Created a Pull request that handles middle clicks like normal clicks => #34

from svelte-spa-router.

TorstenDittmann avatar TorstenDittmann commented on August 15, 2024

Okay, that makes more sense.

Updated my PR #34 for a proposed solution, where every link gets the # in the href.

edit: removed EventListener for links now.

from svelte-spa-router.

avimar avatar avimar commented on August 15, 2024

I think this is the same issue?

<a href="/line/{line.id}" use:link>

When I control or shift click, to open in a new tab or new window, it just opens it in the same tab.

If I use <a href="#/line/{line.id}"> then it seems the router works properly and there's no extra page loads from a full refresh.

Is this a bug to be fixed?

from svelte-spa-router.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.