Comments (5)
@TorstenDittmann thanks for the PR.
I've been thinking about this, and I'm wondering if the best way would actually be to change the handler so it actually modifies the href
element rather than waiting for a click? Otherwise, we'd have to support a lot of cases, such as middle button click, right-click and then "open in new tab", etc...
Thoughts?
from svelte-spa-router.
Could this be solved by looking for the missing hash and additionally maybe the length of window.history
?
Edit: That approach didn't make any sense...
One solution that comes to my mind would be catching the event when somebody clicks with the middle button. The easiest solution would be, redirecting in the current tab when using middle click. But overwriting the behaviour of middle clicks would bug me as a user.
I would love to work on that.
from svelte-spa-router.
Created a Pull request that handles middle clicks like normal clicks => #34
from svelte-spa-router.
Okay, that makes more sense.
Updated my PR #34 for a proposed solution, where every link gets the #
in the href
.
edit: removed EventListener
for links now.
from svelte-spa-router.
I think this is the same issue?
<a href="/line/{line.id}" use:link>
When I control or shift click, to open in a new tab or new window, it just opens it in the same tab.
If I use <a href="#/line/{line.id}">
then it seems the router works properly and there's no extra page loads from a full refresh.
Is this a bug to be fixed?
from svelte-spa-router.
Related Issues (20)
- In vite, i can't use the proxy /dev HOT 1
- Redirection from route pre-condition HOT 5
- Nested routes as maps HOT 1
- If I want to go to the login page in the sidebar + SPA form, is it possible with route guard? HOT 4
- Is this not possible in routeLoaded? HOT 5
- What is the black bar in this image? HOT 2
- Feature request: Svelte 4 support HOT 13
- FEATURE REQUEST: pass next() in precondition to decide whether the router should *change* the current route HOT 1
- Load user data HOT 4
- How to check hash-bashed history HOT 1
- Is there an alternative to the "Failed to fetch dynamically import problem" issue in Vite + Svelte spa environment? HOT 1
- WARNING: The following packages have a svelte field in their package.json but no exports condition for svelte. [email protected] HOT 8
- Typescript problematic types after "wrapping" the route HOT 2
- navigating within same component does not work HOT 5
- Typescript support: Package path ./wrap is not exported from package svelte-spa-router HOT 2
- Will the library support Svelte 5? HOT 5
- Authentication and Authorization HOT 6
- Layouts not exists for svelte-spa-router? HOT 6
- Feature request: Nested route priority HOT 1
- children router bug HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from svelte-spa-router.