isometriks / legacyformbundle Goto Github PK

Should we support being able to add form type extensions by alias as well? Right now it seems that you'd still have to make the form type extension be the actual class name. For Sylius this might be okay as you can use the form class parameter in the extended-type. I thought about making a compiler pass to replace the alias, but for instance your custom_text type would cause problems since it's the same as the TextType class, so replacing it with that would apply the form type extension to both types.

We may be able to override resolveType in FormRegistry to check for FQCN extensions as well as the alias. So if $alias[$name] isset, we can add form extensions for $alias[$name] AND $name. This should prevent the overlap I mentioned earlier.