isivisi / questionablemodules Goto Github PK

View Code? Open in Web Editor NEW

4.0 4.0 1.0 59.25 MB

My collection of VCVRack modules

License: Other

Makefile 0.43% C++ 98.95% Shell 0.62%

audio eurorack oscillator sequencer vcvrack

questionablemodules's Introduction

👋 Hi, I’m @isivisi

I like making useful tools :)

Active Projects

SLURP VST Plugin
Some fun VCVRack modules

Social

questionablemodules's People

Contributors

Stargazers

Watchers

Forkers

steverussell33

questionablemodules's Issues

Allow randomization of Ratio value in Smute

Some way to specify a range of values to randomize, maybe make an expander? or add an option in the context menu

Module: Greenscreen
Plugin Version: 2.1.13
Rack Version: 2.4.1-win-x64
JSON: {"id": 2312771274604655, "plugin": "questionablemodules", "model": "greenscreen", "version": "2.1.13", "params": [], "leftModuleId": 5172919201887855, "rightModuleId": 6237346442742493, "data": {"colorR": 0.0910000279545784, "colorG": 0.094000421464443207, "colorB": 0.091000922024250031, "text": "null", "showText": true, "showInputs": true, "hasShadow": false, "drawRack": false, "boxShadowX": 10.099952697753906, "boxShadowY": 10.000001907348633, "boxShadowColor": {"r": 0.59000009298324585, "g": 0.59100079536437988, "b": 0.59000003337860107, "name": ""}}}
---------- Please describe your problem below: ----------

i've been using Greenscreen for several days, just leaving it in my default patch set to an almost black background and a medium-gray'ish box shadow, with the rack rails turned off. and while playing around with all of the settings a bit more just now, i realized i'm unable to toggle off the box shadows now that they're on. i can change their color just fine, but toggling the context menu item, while updating the menu item display to reflect the toggled state, is not actually toggling the shadows at all. (note, this is not a problem for me, since i like the box shadows a lot lol, but figured i'd raise the issue in case nobody else had.)

Nightbin allow custom urls

Add functionality to add a custom url string for nightbin to check against. Would probably want to be able to set custom tag / or latest releases to check against as well

Nightbin Arm64 crash on destructor

Original post: https://community.vcvrack.com/t/questionable-modules/19301/19

Crashed Thread:        0  Dispatch queue: com.apple.main-thread

Exception Type:        EXC_BAD_ACCESS (SIGSEGV)
Exception Codes:       KERN_INVALID_ADDRESS at 0x0000000000000010
Exception Codes:       0x0000000000000001, 0x0000000000000010

VM Region Info: 0x10 is not in any region.  Bytes before following region: 105553518919664
      REGION TYPE                    START - END         [ VSIZE] PRT/MAX SHRMOD  REGION DETAIL
      UNUSED SPACE AT START
--->  
      MALLOC_NANO (reserved)   600018000000-600020000000 [128.0M] rw-/rwx SM=NUL  ...(unallocated)

Thread 0 Crashed::  Dispatch queue: com.apple.main-thread
0   plugin.dylib                  	       0x129436a7c NightBinWidget::~NightBinWidget() + 112
1   libRack.dylib                 	       0x101774e68 rack::widget::Widget::clearChildren() + 104
2   libRack.dylib                 	       0x101774d48 rack::widget::Widget::~Widget() + 48
3   libRack.dylib                 	       0x1016fa35c rack::app::browser::ModelBox::~ModelBox() + 12
4   libRack.dylib                 	       0x101774e68 rack::widget::Widget::clearChildren() + 104
5   libRack.dylib                 	       0x101774d48 rack::widget::Widget::~Widget() + 48
6   libRack.dylib                 	       0x101773a68 rack::widget::FramebufferWidget::~FramebufferWidget() + 12
7   libRack.dylib                 	       0x101774e68 rack::widget::Widget::clearChildren() + 104
8   libRack.dylib                 	       0x101774d48 rack::widget::Widget::~Widget() + 48
9   libRack.dylib                 	       0x1016fa35c rack::app::browser::ModelBox::~ModelBox() + 12
10  libRack.dylib                 	       0x101774e68 rack::widget::Widget::clearChildren() + 104
11  libRack.dylib                 	       0x101774d48 rack::widget::Widget::~Widget() + 48
12  libRack.dylib                 	       0x1016fa35c rack::app::browser::ModelBox::~ModelBox() + 12
13  libRack.dylib                 	       0x101774e68 rack::widget::Widget::clearChildren() + 104
14  libRack.dylib                 	       0x101774d48 rack::widget::Widget::~Widget() + 48
15  libRack.dylib                 	       0x1016fa35c rack::app::browser::ModelBox::~ModelBox() + 12
16  libRack.dylib                 	       0x101774e68 rack::widget::Widget::clearChildren() + 104
17  libRack.dylib                 	       0x101774d48 rack::widget::Widget::~Widget() + 48
18  libRack.dylib                 	       0x1016fa35c rack::app::browser::ModelBox::~ModelBox() + 12
19  libRack.dylib                 	       0x101774e68 rack::widget::Widget::clearChildren() + 104
20  libRack.dylib                 	       0x101774d48 rack::widget::Widget::~Widget() + 48
21  libRack.dylib                 	       0x101774ed8 rack::widget::Widget::~Widget() + 12
22  libRack.dylib                 	       0x101774e68 rack::widget::Widget::clearChildren() + 104
23  libRack.dylib                 	       0x101774d48 rack::widget::Widget::~Widget() + 48
24  libRack.dylib                 	       0x101774ed8 rack::widget::Widget::~Widget() + 12
25  libRack.dylib                 	       0x101774e68 rack::widget::Widget::clearChildren() + 104
26  libRack.dylib                 	       0x101774d48 rack::widget::Widget::~Widget() + 48
27  libRack.dylib                 	       0x10176e3c4 rack::ui::ScrollWidget::~ScrollWidget() + 48
28  libRack.dylib                 	       0x101774e68 rack::widget::Widget::clearChildren() + 104
29  libRack.dylib                 	       0x101774d48 rack::widget::Widget::~Widget() + 48
30  libRack.dylib                 	       0x1016fb050 rack::app::browser::Browser::~Browser() + 12
31  libRack.dylib                 	       0x101774e68 rack::widget::Widget::clearChildren() + 104
32  libRack.dylib                 	       0x101774d48 rack::widget::Widget::~Widget() + 48
33  libRack.dylib                 	       0x1016fa35c rack::app::browser::ModelBox::~ModelBox() + 12
34  libRack.dylib                 	       0x101774e68 rack::widget::Widget::clearChildren() + 104
35  libRack.dylib                 	       0x101774d48 rack::widget::Widget::~Widget() + 48
36  libRack.dylib                 	       0x101735f38 rack::app::Scene::~Scene() + 48
37  libRack.dylib                 	       0x1016a0fc8 rack::Context::~Context() + 184
38  Rack                          	       0x100c96834 main + 3512
39  dyld                          	       0x196a33f28 start + 2236

Treequencer 2.1.5 regression

Questionable modules v2.1.5 introduced some bugs to Treequencer

outputs 2-8 fail to fire
outputs in general fail to fire when using clock trigger

Issue fixed in commit: bcd7a72

Bugfix will be public once introduced into library: VCVRack/library#747 (comment)

Menu item typos

Typos: Should be Spread not Spead

questionablemodules/src/quatosc.cpp

Line 714 in 7f6fd05

    
           menu->addChild(createMenuItem(mod->normalizeSpreadVolume ? "Disable Spead Volume Normalization" : "Enable Spead Volume Normalization", "",[=]() { mod->normalizeSpreadVolume = !mod->normalizeSpreadVolume; }));

Instant crash when adding any Questionable Module in VCV Rack 2.5.1

Whenever I add any of the modules from this plugin to a patch in VCV Rack 2.5.1, Rack instantly crashes. Here's the relevant bit of the log from a crash after adding SLURP:

[7.898 info src/app/Browser.cpp:88 chooseModel] Creating module Questionable Modules SLURP
[7.906 fatal adapters/standalone.cpp:49 fatalSignalHandler] Fatal signal 6. Stack trace:
29: ./Rack() [0x40435d]
28: /usr/lib/libc.so.6(+0x3c770)
27: /usr/lib/libc.so.6(+0x8d32c)
26: /usr/lib/libc.so.6(gsignal+0x18)
25: /usr/lib/libc.so.6(abort+0xd7)
24: ./libRack.so(+0x279854)
23: ./libRack.so(__cxxabiv1::__terminate(void (*)())+0x6)
22: ./libRack.so(+0x7bc631)
21: ./libRack.so(+0x7bc784)
20: ./libRack.so(std::__throw_logic_error(char const*)+0x3d)
19: /home/username/.local/share/Rack2/plugins-lin-x64/questionablemodules/plugin.so(+0xacc8f)
18: /home/username/.local/share/Rack2/plugins-lin-x64/questionablemodules/plugin.so(QuatOSC::QuatOSC()+0x13c)
17: /home/username/.local/share/Rack2/plugins-lin-x64/questionablemodules/plugin.so(rack::createModel<QuatOSC, QuatOSCWidget>(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >)::TModel::createModule()+0x1f)
16: ./libRack.so(+0x382816)
15: ./libRack.so(rack::app::browser::ModelBox::onButton(rack::widget::Widget::ButtonEvent const&)+0x2a9)
14: ./libRack.so(rack::widget::Widget::onButton(rack::widget::Widget::ButtonEvent const&)+0xed)
13: ./libRack.so(rack::widget::Widget::onButton(rack::widget::Widget::ButtonEvent const&)+0xed)
12: ./libRack.so(rack::widget::Widget::onButton(rack::widget::Widget::ButtonEvent const&)+0xed)
11: ./libRack.so(rack::ui::ScrollWidget::onButton(rack::widget::Widget::ButtonEvent const&)+0x103)
10: ./libRack.so(rack::app::browser::Browser::onButton(rack::widget::Widget::ButtonEvent const&)+0xfd)
9: ./libRack.so(rack::ui::MenuOverlay::onButton(rack::widget::Widget::ButtonEvent const&)+0x11d)
8: ./libRack.so(rack::widget::OpaqueWidget::onButton(rack::widget::Widget::ButtonEvent const&)+0x105)
7: ./libRack.so(rack::widget::EventState::handleButton(rack::math::Vec, int, int, int)+0x269)
6: ./libRack.so(_glfwPollEventsX11+0xfdf)
5: ./libRack.so(rack::window::Window::step()+0x84)
4: ./libRack.so(rack::window::Window::run()+0x28)
3: ./Rack(main+0xe7d)
2: /usr/lib/libc.so.6(+0x25cd0)
1: /usr/lib/libc.so.6(__libc_start_main+0x8a)
0: ./Rack() [0x404289]

I get a similar crash when I add any of the other modules.

As far as I can tell, this started happening after the update to VCV Rack 2.5. I'm using the version of this plugin installed from the VCV Library with the vcvrack-bin 2.5.1-2 AUR package on Arch Linux. I tried removing and reinstalling the plugin, but that didn't help.

Thanks for your work on this plugin; SLURP is one of my favorite oscillators to play with!

Greenscreen Bug Report

Module: Greenscreen
Plugin Version: 2.1.10
JSON: {"id": 8998864862134520, "plugin": "questionablemodules", "model": "greenscreen", "version": "2.1.10", "params": [], "data": {"colorR": 0.015686275437474251, "colorG": 0.95686280727386475, "colorB": 0.015686275437474251, "text": "Green", "showText": true}}
---------- Please describe your problem below: ----------

Greenscreen Custom Background Images

I love how its sets a mood for my patches but sometimes a solid color wont do. I'd appreciate it if I could put in my own pictures of stuff. keep up the great work though!

No panel labels on linux, though they are present in the module browser.

Treequencer crash

[14.010 fatal adapters/standalone.cpp:49 fatalSignalHandler] Fatal signal 11. Stack trace:
11: ./Rack() [0x4042ed]
10: /usr/lib/libc.so.6(+0x3e710)
9: /home/isivisi/.Rack2/plugins-lin-x64/questionablemodules/plugin.so(Treequencer::processSequence(bool)+0xa6)
8: /home/isivisi/.Rack2/plugins-lin-x64/questionablemodules/plugin.so(Treequencer::process(rack::engine::Module::ProcessArgs const&)+0x52f)
7: ./libRack.so(rack::engine::Module::doProcess(rack::engine::Module::ProcessArgs const&)+0x9dc)
6: ./libRack.so(rack::engine::Engine::stepBlock(int)+0x749)
5: ./libRack.so(rack::audio::Device::processBuffer(float const*, int, float*, int, int)+0x143)
4: ./libRack.so(rack::RtAudioDevice::rtAudioCallback(void*, void*, unsigned int, double, unsigned int, void*)+0xa3)
3: ./libRack.so(+0x79ee02)
2: ./libRack.so(+0x79f325)
1: /usr/lib/libc.so.6(+0x8c9eb)
0: /usr/lib/libc.so.6(+0x110dfc)

toggling bounce while there is no active seqeuence in sequence mode ends it all.

should probably force a sequence to be generated the moment its toggled

edit: actually its a size_t being set to -1

Modules crash Rack when opening module browser

Thread 0 Crashed::  Dispatch queue: com.apple.main-thread
0   plugin.dylib                  	       0x12cbb0dc0 QuestionableWidget::setWidgetTheme(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>>, bool) + 32
1   plugin.dylib                  	       0x12cbaeccc QuestionableWidget::step() + 124
2   libRack.dylib                 	       0x100b68fe4 rack::app::browser::ModelBox::createPreview() + 504
3   libRack.dylib                 	       0x100b68930 rack::app::browser::ModelBox::draw(rack::widget::Widget::DrawArgs const&) + 36
4   libRack.dylib                 	       0x100bd980c rack::widget::Widget::draw(rack::widget::Widget::DrawArgs const&) + 136
5   libRack.dylib                 	       0x100bd980c rack::widget::Widget::draw(rack::widget::Widget::DrawArgs const&) + 136
6   libRack.dylib                 	       0x100bd980c rack::widget::Widget::draw(rack::widget::Widget::DrawArgs const&) + 136
7   libRack.dylib                 	       0x100bd980c rack::widget::Widget::draw(rack::widget::Widget::DrawArgs const&) + 136
8   libRack.dylib                 	       0x100bd24a0 rack::ui::ScrollWidget::draw(rack::widget::Widget::DrawArgs const&) + 48
9   libRack.dylib                 	       0x100bd980c rack::widget::Widget::draw(rack::widget::Widget::DrawArgs const&) + 136
10  libRack.dylib                 	       0x100bd980c rack::widget::Widget::draw(rack::widget::Widget::DrawArgs const&) + 136
11  libRack.dylib                 	       0x100bd980c rack::widget::Widget::draw(rack::widget::Widget::DrawArgs const&) + 136
12  libRack.dylib                 	       0x100bde6e0 rack::window::Window::step() + 1728
13  libRack.dylib                 	       0x100bde008 rack::window::Window::run() + 40
14  Rack                          	       0x1000fa7e0 main + 3428
15  dyld                          	       0x1a44cff28 start + 2236

Internal clock of Treequencer & Smute never align with other clocked systems on startup

Smute & Treequencer clocks never seem to initially line up with other sequencers / clocked tools in vcvrack on startup. running all modules through a reset at the same time fixes this but its weird behavior.

Don't know what is causing this yet.