Use other exception instead of assertionError? about nnsmith HOT 11 CLOSED

so why do we want to catch the assertion error?

from nnsmith.

have we fixed this issue?

from nnsmith.

@lazycal You mean we shall replace all internal assertion exception into some kind of customized one, right?

from nnsmith.

yes

from nnsmith.

OK, let's use NNSmithInternalError. I will update my parts and send a PR soon.

from nnsmith.

@lazycal I forgot to make a PR so could manually take a look at 4fe4140 to see if that is what you expected?

from nnsmith.

@lazycal

46c8da3

Should look better now. Use SanityCheck.$FUNC() to do fatal check (i.e., internal errors). Use ConstraintCheck.$FUNC() to assert some constraint properties which can be expectedly caught if not sat.

Please consider closing this issue if nothing else.

from nnsmith.

Thanks. This works. I accept this commit.

One question for curiosity: what I initially wanted is much simpler. That is, we only create a new type of error ConstraintError but still use python's native AssertionError as NNSmithInternalError. I don't see any reason against it?

from nnsmith.

Because we have no idea if any other standard lib or 3rd-party lib will use AssertionError to mess things up. So it is always good to distinguish the Exception type when considering catching it as any sort of hints. @lazycal

from nnsmith.

Do you mean you want to ignore 3rd-party's assertionerror?

from nnsmith.

Oh, I see you mean internal error. All errors except ConstraintError should cause our attention. In this case, it is OK to use AssertionError. I use NNSmithInternalError just to make things consistent (it has been used elsewhere before).

from nnsmith.