💡 [REQUEST] - Tutorial of adding a new operator for GIR about nnsmith HOT 4 CLOSED

Hi @ganler , thank you so much for your detailed answer. The explanations and examples are very clear to me, so I close this issue.

BTW, most of NNSmith's code is well-designed and self-explanatory, nice job!

from nnsmith.

Hi Chijin, your understanding is basically correct! There are a few more details / resources that can be helpful:

Adding an operator requires a specification. You can learn about the concept of an operator specification/rule via:

• Section 2 of NeuRI paper (https://arxiv.org/pdf/2302.02261.pdf)
• Section 3.1 of NNSmith (https://arxiv.org/pdf/2207.13066.pdf)

Regarding implementation of op spec, you can find the quick tutorial in https://github.com/ise-uiuc/nnsmith/blob/main/doc/concept.md and various examples in:

• nnsmith/abstract/op.py: if the op is very general;
• nnsmith/materialize/torch/dialect.py: if the op is specific to PyTorch operators;
• nnsmith/materialize/tensorflow/dialect.py: if the op is specific to TF operators;

Once you are done with defining an operator specification. You can materialize the operator in https://github.com/ise-uiuc/nnsmith/blob/main/nnsmith/materialize/torch/forward.py (for PyTorch) or https://github.com/ise-uiuc/nnsmith/blob/main/nnsmith/materialize/tensorflow/forward.py (for TF).

from nnsmith.

As a reference, you may find this PR a helpful example: https://github.com/ise-uiuc/nnsmith/pull/98/files

from nnsmith.

In your case of Split, please note that the modeling of operators in NNSmith requires the number of inputs/outputs to be fixed. A typical split operator could variadic outputs (https://pytorch.org/docs/stable/generated/torch.split.html). Nonetheless, you can still implement multiple versions of Split, say Split1 (only one output), Split2 (2 outputs, etc)... You follow how Concat is implemented for reference: https://github.com/ise-uiuc/nnsmith/blob/main/nnsmith/abstract/op.py#L1904

Let me know if you have more questions. Sorry for the incomplete documents -- will enhance it as long as I have time at hand. For now please feel free to submit an issue and ping me for any undocument questions! Thanks!

from nnsmith.